netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Scott Feldman <sfeldma@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: rocker: Change netdev names to include slot number
Date: Mon, 02 Feb 2015 14:41:52 -0700	[thread overview]
Message-ID: <54CFEF20.8060300@gmail.com> (raw)
In-Reply-To: <CAE4R7bA0Ea9zugm=OR0EN2qSeoiROEoMiYZ-5YMwd9UdS4L0Sg@mail.gmail.com>

On 2/2/15 2:33 PM, Scott Feldman wrote:
> On Sun, Feb 1, 2015 at 10:03 PM, David Ahern <dsahern@gmail.com> wrote:
>> Currently, rocker devices are given eth%d names. If you have multiple
>> rocker devices it is difficult to easily correlate eth%d names to a
>> rocker device and port. Change the device name to sw + PCI slot
>> number + p + id (sw%dp%d). This makes the device names easier to
>> correlate. ie., Rather than eth0, ..., eth N (N = number of ports in
>> device) the ports get netdev names like sw5p0, ..., sw5pN.
>
> I think udev is the preferred tool for interface naming, rather than
> hard-coding interface names in the driver.
>


hmmm...  What I am seeing right now is a race as to which devices are 
detected first -- rocker or virtio. On half of the boots the virtio are 
detected first and named eth0 and eth1. The other half of the boots 
virtio devices are detected last and become ethN+1 and ethN+2 (N=number 
of rocker ports) -- which makes it a PITA to script commands. AFAIK udev 
won't solve that problem.

David

  reply	other threads:[~2015-02-02 21:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02  6:03 [PATCH] net: rocker: Change netdev names to include slot number David Ahern
2015-02-02 21:33 ` Scott Feldman
2015-02-02 21:41   ` David Ahern [this message]
2015-02-02 22:03     ` Florian Fainelli
2015-02-02 22:09       ` David Ahern
2015-02-03  5:46         ` Scott Feldman
2015-02-03 16:06           ` David Ahern
2015-02-03  7:33         ` Rosen, Rami
2015-02-02 22:16     ` David Miller
2015-02-02 22:15   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CFEF20.8060300@gmail.com \
    --to=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).