From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Bas Peters <baspeters93@gmail.com>, isdn@linux-pingi.de
Cc: julia.lawall@lip6.fr, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] drivers: isdn: act2000: capi.c: fix checkpatch errors
Date: Sat, 07 Feb 2015 20:51:59 +0300 [thread overview]
Message-ID: <54D650BF.5000400@cogentembedded.com> (raw)
In-Reply-To: <1423328797-17865-3-git-send-email-baspeters93@gmail.com>
Hello.
On 02/07/2015 08:06 PM, Bas Peters wrote:
> This patch fixes the following checkpatch errors:
> 1. trailing statement
> 1. assignment of variable in if condition
> 1. incorrectly placed brace after function definition
> Signed-off-by: Bas Peters <baspeters93@gmail.com>
> ---
> drivers/isdn/act2000/capi.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
> diff --git a/drivers/isdn/act2000/capi.c b/drivers/isdn/act2000/capi.c
> index 3f66ca2..5d677e6 100644
> --- a/drivers/isdn/act2000/capi.c
> +++ b/drivers/isdn/act2000/capi.c
> @@ -113,7 +113,8 @@ actcapi_chkhdr(act2000_card *card, actcapi_msghdr *hdr)
> m->hdr.cmd.cmd = c; \
> m->hdr.cmd.subcmd = s; \
> m->hdr.msgnum = actcapi_nextsmsg(card); \
> - } else m = NULL; \
> + } else
> + m = NULL; \
Documentation/CodingStyle has an extra rule for such case: *else* branch
should also have {} since *if* branch has {}.
[...]
WNR, Sergei
next prev parent reply other threads:[~2015-02-07 17:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 17:06 [PATCH 0/6] drivers: isdn: act2000: fix a variety of checkpatch errors Bas Peters
2015-02-07 17:06 ` [PATCH 1/6] drivers: isdn: act2000: act2000_isa.c: Fix " Bas Peters
2015-02-07 17:06 ` [PATCH 2/6] drivers: isdn: act2000: capi.c: fix " Bas Peters
2015-02-07 17:51 ` Sergei Shtylyov [this message]
2015-02-07 18:02 ` Bas Peters
2015-02-07 18:02 ` Julia Lawall
2015-02-07 18:08 ` Bas Peters
2015-02-07 18:25 ` Sergei Shtylyov
2015-02-07 19:19 ` Joe Perches
2015-02-07 20:43 ` Paul Bolle
2015-02-07 20:55 ` Bas Peters
2015-02-07 21:04 ` Joe Perches
2015-02-08 19:47 ` Kill I4L? (was: [PATCH 2/6] drivers: isdn: act2000: capi.c: fix checkpatch errors) Tilman Schmidt
2015-02-08 20:04 ` Joe Perches
2015-02-08 23:59 ` Kill I4L? Karsten Keil
2015-02-09 10:07 ` Bas Peters
2015-02-09 10:53 ` Tilman Schmidt
2015-02-09 19:48 ` One Thousand Gnomes
2015-02-09 12:12 ` Paul Bolle
2015-02-07 17:06 ` [PATCH 3/6] drivers: isdn: act2000: module.c: remove assignments of variables in if conditions Bas Peters
2015-02-07 17:06 ` [PATCH 4/6] drivers: isdn: act2000: module.c: remove NULL-initialization of static variable Bas Peters
2015-02-07 17:06 ` [PATCH 5/6] drivers: isdn: act2000: module.c: remove parenthesres around return values Bas Peters
2015-02-07 17:06 ` [PATCH 6/6] drivers: isdn: act2000: fix wrongly positioned brace Bas Peters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D650BF.5000400@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=baspeters93@gmail.com \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).