From: nick <xerofoify@gmail.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: linux.nics@intel.com, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org, bruce.w.allan@intel.com,
jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
john.ronciak@intel.com
Subject: Re: [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210
Date: Sun, 08 Feb 2015 20:28:24 -0500 [thread overview]
Message-ID: <54D80D38.3080708@gmail.com> (raw)
In-Reply-To: <1423445167.2589.167.camel@jtkirshe-mobl>
On 2015-02-08 08:26 PM, Jeff Kirsher wrote:
> On Sun, 2015-02-08 at 17:21 -0800, Jeff Kirsher wrote:
>> On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote:
>>> Removes the outdated fix me comment in the
>>> function,gb_acquire_swfw_sync_i210
>>> for setting the variables, i and timeout to the intended correct
>>> values for
>>> the function,gb_acquire_swfw_sync_i210 to function correctly. This
>>> comment is
>>> no longer due to these values having been no changed in the last few
>>> years and
>>> no known issues have been found for these variables being set to their
>>> current
>>> values. Due to this the comment can now be removed as the values set
>>> for these
>>> variables are known to be correct after years of no known issues or
>>> bugs related
>>> to their current values.
>>>
>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>> ---
>>> drivers/net/ethernet/intel/igb/e1000_i210.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Thank Nick, I will add your patch to my queue.
>
> Oh and the title should be "igb: Remove outdated ...", not
> "net:ethernet:intel: Remove ..."
>
Jeff,
Sorry about the title. Good to known for next time. Should I resend or
will you fix the title for me?
Cheers,
Nick
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2015-02-09 1:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 5:21 [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210 Nicholas Krause
2015-02-09 1:21 ` Jeff Kirsher
2015-02-09 1:26 ` Jeff Kirsher
2015-02-09 1:28 ` nick [this message]
2015-02-09 1:29 ` [E1000-devel] " Jeff Kirsher
2015-02-09 7:17 ` [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function,gb_acquire_swfw_sync_i210 Andrej Manduch
2015-02-09 8:32 ` Jeff Kirsher
2015-02-09 9:29 ` Bjørn Mork
2015-02-09 9:35 ` Jeff Kirsher
2015-02-09 17:03 ` [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210 Hisashi T Fujinaka
2015-02-09 19:35 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D80D38.3080708@gmail.com \
--to=xerofoify@gmail.com \
--cc=bruce.w.allan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.nics@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).