From: Colin Ian King <colin.king@canonical.com>
To: Kalle Valo <kvalo@codeaurora.org>, Eric Dumazet <eric.dumazet@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: ratelimit skb allocation failure message
Date: Tue, 10 Feb 2015 13:52:23 +0000 [thread overview]
Message-ID: <54DA0D17.7070403@canonical.com> (raw)
In-Reply-To: <87a90lop1x.fsf@kamboji.qca.qualcomm.com>
On 10/02/15 13:48, Kalle Valo wrote:
> Eric Dumazet <eric.dumazet@gmail.com> writes:
>
>> On Tue, 2015-02-10 at 08:54 +0000, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> when running low on memory I noticed rtlwifi was producing a large
>>> quantity of repeated skb allocation failures messages. This should
>>> be ratelimited to reduce the noise.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/net/wireless/rtlwifi/pci.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
>>> index c70efb9..ca0fd50 100644
>>> --- a/drivers/net/wireless/rtlwifi/pci.c
>>> +++ b/drivers/net/wireless/rtlwifi/pci.c
>>> @@ -817,7 +817,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
>>> /* get a new skb - if fail, old one will be reused */
>>> new_skb = dev_alloc_skb(rtlpci->rxbuffersize);
>>> if (unlikely(!new_skb)) {
>>> - pr_err("Allocation of new skb failed in %s\n",
>>> + pr_err_ratelimited("Allocation of new skb failed in %s\n",
>>> __func__);
>>
>> Or even better, remove the message.
>
> There's actually a pending patch for that, I'll send it to Dave ASAP:
>
> https://patchwork.kernel.org/patch/5671121/
>
Thanks!
prev parent reply other threads:[~2015-02-10 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 8:54 [PATCH] rtlwifi: ratelimit skb allocation failure message Colin King
2015-02-10 13:17 ` Eric Dumazet
2015-02-10 13:48 ` Kalle Valo
2015-02-10 13:52 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DA0D17.7070403@canonical.com \
--to=colin.king@canonical.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=eric.dumazet@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).