* [PATCH] rtlwifi: ratelimit skb allocation failure message
@ 2015-02-10 8:54 Colin King
2015-02-10 13:17 ` Eric Dumazet
0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2015-02-10 8:54 UTC (permalink / raw)
To: Larry Finger, Chaoming Li, Kalle Valo, linux-wireless, netdev
Cc: linux-kernel, Colin King
From: Colin Ian King <colin.king@canonical.com>
when running low on memory I noticed rtlwifi was producing a large
quantity of repeated skb allocation failures messages. This should
be ratelimited to reduce the noise.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/rtlwifi/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index c70efb9..ca0fd50 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -817,7 +817,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
/* get a new skb - if fail, old one will be reused */
new_skb = dev_alloc_skb(rtlpci->rxbuffersize);
if (unlikely(!new_skb)) {
- pr_err("Allocation of new skb failed in %s\n",
+ pr_err_ratelimited("Allocation of new skb failed in %s\n",
__func__);
goto no_new;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rtlwifi: ratelimit skb allocation failure message
2015-02-10 8:54 [PATCH] rtlwifi: ratelimit skb allocation failure message Colin King
@ 2015-02-10 13:17 ` Eric Dumazet
2015-02-10 13:48 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2015-02-10 13:17 UTC (permalink / raw)
To: Colin King
Cc: Larry Finger, Chaoming Li, Kalle Valo, linux-wireless, netdev,
linux-kernel
On Tue, 2015-02-10 at 08:54 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> when running low on memory I noticed rtlwifi was producing a large
> quantity of repeated skb allocation failures messages. This should
> be ratelimited to reduce the noise.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/rtlwifi/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index c70efb9..ca0fd50 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -817,7 +817,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
> /* get a new skb - if fail, old one will be reused */
> new_skb = dev_alloc_skb(rtlpci->rxbuffersize);
> if (unlikely(!new_skb)) {
> - pr_err("Allocation of new skb failed in %s\n",
> + pr_err_ratelimited("Allocation of new skb failed in %s\n",
> __func__);
Or even better, remove the message.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtlwifi: ratelimit skb allocation failure message
2015-02-10 13:17 ` Eric Dumazet
@ 2015-02-10 13:48 ` Kalle Valo
2015-02-10 13:52 ` Colin Ian King
0 siblings, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2015-02-10 13:48 UTC (permalink / raw)
To: Eric Dumazet
Cc: Colin King, Larry Finger, Chaoming Li, linux-wireless, netdev,
linux-kernel
Eric Dumazet <eric.dumazet@gmail.com> writes:
> On Tue, 2015-02-10 at 08:54 +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> when running low on memory I noticed rtlwifi was producing a large
>> quantity of repeated skb allocation failures messages. This should
>> be ratelimited to reduce the noise.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/net/wireless/rtlwifi/pci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
>> index c70efb9..ca0fd50 100644
>> --- a/drivers/net/wireless/rtlwifi/pci.c
>> +++ b/drivers/net/wireless/rtlwifi/pci.c
>> @@ -817,7 +817,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
>> /* get a new skb - if fail, old one will be reused */
>> new_skb = dev_alloc_skb(rtlpci->rxbuffersize);
>> if (unlikely(!new_skb)) {
>> - pr_err("Allocation of new skb failed in %s\n",
>> + pr_err_ratelimited("Allocation of new skb failed in %s\n",
>> __func__);
>
> Or even better, remove the message.
There's actually a pending patch for that, I'll send it to Dave ASAP:
https://patchwork.kernel.org/patch/5671121/
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtlwifi: ratelimit skb allocation failure message
2015-02-10 13:48 ` Kalle Valo
@ 2015-02-10 13:52 ` Colin Ian King
0 siblings, 0 replies; 4+ messages in thread
From: Colin Ian King @ 2015-02-10 13:52 UTC (permalink / raw)
To: Kalle Valo, Eric Dumazet
Cc: Larry Finger, Chaoming Li, linux-wireless, netdev, linux-kernel
On 10/02/15 13:48, Kalle Valo wrote:
> Eric Dumazet <eric.dumazet@gmail.com> writes:
>
>> On Tue, 2015-02-10 at 08:54 +0000, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> when running low on memory I noticed rtlwifi was producing a large
>>> quantity of repeated skb allocation failures messages. This should
>>> be ratelimited to reduce the noise.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/net/wireless/rtlwifi/pci.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
>>> index c70efb9..ca0fd50 100644
>>> --- a/drivers/net/wireless/rtlwifi/pci.c
>>> +++ b/drivers/net/wireless/rtlwifi/pci.c
>>> @@ -817,7 +817,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
>>> /* get a new skb - if fail, old one will be reused */
>>> new_skb = dev_alloc_skb(rtlpci->rxbuffersize);
>>> if (unlikely(!new_skb)) {
>>> - pr_err("Allocation of new skb failed in %s\n",
>>> + pr_err_ratelimited("Allocation of new skb failed in %s\n",
>>> __func__);
>>
>> Or even better, remove the message.
>
> There's actually a pending patch for that, I'll send it to Dave ASAP:
>
> https://patchwork.kernel.org/patch/5671121/
>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-10 13:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-10 8:54 [PATCH] rtlwifi: ratelimit skb allocation failure message Colin King
2015-02-10 13:17 ` Eric Dumazet
2015-02-10 13:48 ` Kalle Valo
2015-02-10 13:52 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).