netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Andrew Lunn <andrew@lunn.ch>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] Indirect phy access for mv88e6171
Date: Sun, 15 Feb 2015 10:32:40 -0800	[thread overview]
Message-ID: <54E0E648.8080206@roeck-us.net> (raw)
In-Reply-To: <1423937871-9180-1-git-send-email-andrew@lunn.ch>

On 02/14/2015 10:17 AM, Andrew Lunn wrote:
> These two patches allow the mv88e6171 driver to access the port phys
> using indirect addressing. Depending on pin strapping, the switch
> either uses a single address on the host MDIO bus, requiring the port
> phys are accessed indirectly, or the switch uses a number of addresses
> on the host bus and the phys can be directly accessed.
>
> The 370RD, the first supported platform to use the 6171 uses multiple
> addresses, so this indirect mode was not required. However the
> WRT1900AC has the switch configured to use a single address, and so
> indirect access is needed.
>
> The mv88e6352 already has all the needed code. Refactor it into the
> shared mv88e6xxx and then use it in the mv88e6171 driver.
>
> Tested on the 370RD and WRT1900AC.
>
> It would be good if Guenter Roeck could test on his platform to ensure
> i've not broken anything for the mv88e6352.
>

I'll try. My primary problem right now is that I run Lennert Buytenhek's
patch set to support bridging offload (aka hardware bridging) on top of
the upstream dsa code, and the upstream code now supports a competing /
alternate means  to support bridging/switching offload (NET_SWITCHDEV)
which doesn't work with dsa (at least not yet). So I'll have to figure
out if / how I can run your patches with my code base, or how I can add
add support for NET_SWITCHDEV into dsa.

Do you know if there are any efforts going on in that direction ?

Thanks,
Guenter

  parent reply	other threads:[~2015-02-15 18:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-14 18:17 [PATCH 0/2] Indirect phy access for mv88e6171 Andrew Lunn
2015-02-14 18:17 ` [PATCH 1/2] net: dsa: mv88e6352: Refactor shareable code Andrew Lunn
2015-02-16  3:09   ` Guenter Roeck
2015-02-14 18:17 ` [PATCH 2/2] net: dsa: mv88e6171: Enable access to phys via internal mdio bus Andrew Lunn
2015-02-15 18:32 ` Guenter Roeck [this message]
2015-02-15 20:25   ` [PATCH 0/2] Indirect phy access for mv88e6171 Andrew Lunn
2015-02-15 21:05     ` Florian Fainelli
2015-02-15 22:20       ` Guenter Roeck
2015-02-19 20:54 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E0E648.8080206@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).