From: roopa <roopa@cumulusnetworks.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Scott Feldman" <sfeldma@gmail.com>,
"Jiří Pírko" <jiri@resnulli.us>, netdev <netdev@vger.kernel.org>,
"Stephen Hemminger" <stephen@networkplumber.org>
Subject: Re: Port STP state after removing port from bridge
Date: Wed, 18 Feb 2015 20:54:02 -0800 [thread overview]
Message-ID: <54E56C6A.1060108@cumulusnetworks.com> (raw)
In-Reply-To: <CAGVrzcZMV3vSd3hEsXqk6BtyU-Ts9=oJvb79DTZp25TnnGm5CQ@mail.gmail.com>
On 2/18/15, 8:39 PM, Florian Fainelli wrote:
> Hi,
>
> It just occured to me that the following sequence:
>
> brctl addbr br0
> brctl addif br0 port0
> ... STP happens
> brctl delif br0 port0
>
> will leave port0 in STP disabled state, because the bridge code will
> set the STP state to DISABLED, and only a down/up sequence can bring
> it back to FORWARDING.
>
> Is this something that we should somehow fix? As an user it seems a
> little convoluted having to do a down/up sequence to restore things. I
> believe however that it is valid for the bridge layer to mark a port
> as DISABLED when removing it. This is typically not noticed or even
> remotely a problem with software bridges because we cannot enforce an
> actual STP state at the HW level.
>
Just curious, Are you only talking about hw state being left it DISABLED
state in the switchdev context ?.
If yes, then cant the switch driver who is already listening to port
leave msgs, clear the disabled state on the port. ?
next prev parent reply other threads:[~2015-02-19 4:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 4:39 Port STP state after removing port from bridge Florian Fainelli
2015-02-19 4:54 ` roopa [this message]
2015-02-19 5:00 ` Florian Fainelli
2015-02-19 5:28 ` roopa
2015-02-20 4:46 ` Scott Feldman
[not found] ` <CAE4R7bBSbwi93t05Z+rB2JgzFYdZ+m44AFSzU7JkwdHRWzz1Mw@mail.gmail.com>
2015-02-20 10:00 ` Jiri Pirko
2015-02-20 15:03 ` Scott Feldman
2015-02-20 17:04 ` Florian Fainelli
2015-02-21 19:43 ` Scott Feldman
2015-02-21 20:26 ` Florian Fainelli
2015-02-21 22:58 ` Stephen Hemminger
2015-02-22 2:49 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E56C6A.1060108@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).