netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: roopa <roopa@cumulusnetworks.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
	vyasevic@redhat.com, wkok@cumulusnetworks.com, sfeldma@gmail.com,
	Jamal Hadi Salim <hadi@mojatatu.com>,
	Andy Gospodarek <gospo@cumulusnetworks.com>
Subject: Re: [PATCH net-next v3 0/2] iproute2: bridge vlan range support
Date: Thu, 19 Feb 2015 18:08:23 -0800	[thread overview]
Message-ID: <54E69717.3050306@cumulusnetworks.com> (raw)
In-Reply-To: <20150205104809.603763cf@urahara>

On 2/5/15, 10:48 AM, Stephen Hemminger wrote:
> On Sun, 25 Jan 2015 18:26:23 -0800
> roopa@cumulusnetworks.com wrote:
>
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> This series adds support for vlan ranges in iproute2 bridge add
>> and show commands.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>> Signed-off-by: Wilson Kok <wkok@cumulusnetworks.com>
>>
>> Roopa Prabhu (2):
>>    iproute2: bridge: support vlan range for adds
>>    iproute2: bridge vlan show new option to print ranges
>>
>>   bridge/br_common.h        |    1 +
>>   bridge/bridge.c           |    6 ++++-
>>   bridge/vlan.c             |   55 ++++++++++++++++++++++++++++++++++++++++-----
>>   include/linux/if_bridge.h |    2 ++
>>   include/linux/rtnetlink.h |    1 +
>>   5 files changed, 58 insertions(+), 7 deletions(-)
>>
> Applied to net-next branch of iproute2
> Go ahead and send more patches if you decide on different output format.

Thanks stephen.

Maybe too late, but wanted to add a note.
I would have loved to have the default output print vlan ranges if the 
iproute2 version is capable and is talking to the kernel which has vlan 
range support. The netlink msg handling takes care of back ward 
compatibility.

I think, I was being too cautious to not break users who might be doing 
screen scraping.
In general should i be too worried about breaking such users ?.
If not, I would love to resubmit the patch to make the default output 
print ranges.

  reply	other threads:[~2015-02-20  2:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26  2:26 [PATCH net-next v3 0/2] iproute2: bridge vlan range support roopa
2015-02-05 18:48 ` Stephen Hemminger
2015-02-20  2:08   ` roopa [this message]
2015-02-20  5:09     ` Scott Feldman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E69717.3050306@cumulusnetworks.com \
    --to=roopa@cumulusnetworks.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=hadi@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=sfeldma@gmail.com \
    --cc=shemminger@vyatta.com \
    --cc=stephen@networkplumber.org \
    --cc=vyasevic@redhat.com \
    --cc=wkok@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).