From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Subject: Re: [PATCH net-next v3 0/2] iproute2: bridge vlan range support Date: Thu, 19 Feb 2015 18:08:23 -0800 Message-ID: <54E69717.3050306@cumulusnetworks.com> References: <1422239185-14054-1-git-send-email-roopa@cumulusnetworks.com> <20150205104809.603763cf@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, shemminger@vyatta.com, vyasevic@redhat.com, wkok@cumulusnetworks.com, sfeldma@gmail.com, Jamal Hadi Salim , Andy Gospodarek To: Stephen Hemminger Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:33431 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753417AbbBTCIZ (ORCPT ); Thu, 19 Feb 2015 21:08:25 -0500 Received: by pabkx10 with SMTP id kx10so4327328pab.0 for ; Thu, 19 Feb 2015 18:08:24 -0800 (PST) In-Reply-To: <20150205104809.603763cf@urahara> Sender: netdev-owner@vger.kernel.org List-ID: On 2/5/15, 10:48 AM, Stephen Hemminger wrote: > On Sun, 25 Jan 2015 18:26:23 -0800 > roopa@cumulusnetworks.com wrote: > >> From: Roopa Prabhu >> >> This series adds support for vlan ranges in iproute2 bridge add >> and show commands. >> >> Signed-off-by: Roopa Prabhu >> Signed-off-by: Wilson Kok >> >> Roopa Prabhu (2): >> iproute2: bridge: support vlan range for adds >> iproute2: bridge vlan show new option to print ranges >> >> bridge/br_common.h | 1 + >> bridge/bridge.c | 6 ++++- >> bridge/vlan.c | 55 ++++++++++++++++++++++++++++++++++++++++----- >> include/linux/if_bridge.h | 2 ++ >> include/linux/rtnetlink.h | 1 + >> 5 files changed, 58 insertions(+), 7 deletions(-) >> > Applied to net-next branch of iproute2 > Go ahead and send more patches if you decide on different output format. Thanks stephen. Maybe too late, but wanted to add a note. I would have loved to have the default output print vlan ranges if the iproute2 version is capable and is talking to the kernel which has vlan range support. The netlink msg handling takes care of back ward compatibility. I think, I was being too cautious to not break users who might be doing screen scraping. In general should i be too worried about breaking such users ?. If not, I would love to resubmit the patch to make the default output print ranges.