* [PATCH net-next] ethtool: Add hw-switch-offload to netdev_features_strings.
@ 2015-02-20 22:50 Rami Rosen
2015-02-20 19:09 ` David Miller
2015-02-21 17:31 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Rami Rosen @ 2015-02-20 22:50 UTC (permalink / raw)
To: davem; +Cc: netdev, roopa, Rami Rosen
commit aafb3e98b279 (netdev: introduce new NETIF_F_HW_SWITCH_OFFLOAD feature
flag for switch device offloads) added a new feature without adding it to
netdev_features_strings array; this patch fixes this.
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
net/core/ethtool.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 91f74f3..fc5feda 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -98,6 +98,7 @@ static const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN]
[NETIF_F_RXALL_BIT] = "rx-all",
[NETIF_F_HW_L2FW_DOFFLOAD_BIT] = "l2-fwd-offload",
[NETIF_F_BUSY_POLL_BIT] = "busy-poll",
+ [NETIF_F_HW_SWITCH_OFFLOAD_BIT] = "hw-switch-offload",
};
static const char
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ethtool: Add hw-switch-offload to netdev_features_strings.
2015-02-20 22:50 [PATCH net-next] ethtool: Add hw-switch-offload to netdev_features_strings Rami Rosen
@ 2015-02-20 19:09 ` David Miller
2015-02-21 17:31 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-02-20 19:09 UTC (permalink / raw)
To: ramirose; +Cc: netdev, roopa
From: Rami Rosen <ramirose@gmail.com>
Date: Sat, 21 Feb 2015 00:50:48 +0200
> @@ -98,6 +98,7 @@ static const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN]
> [NETIF_F_RXALL_BIT] = "rx-all",
> [NETIF_F_HW_L2FW_DOFFLOAD_BIT] = "l2-fwd-offload",
> [NETIF_F_BUSY_POLL_BIT] = "busy-poll",
> + [NETIF_F_HW_SWITCH_OFFLOAD_BIT] = "hw-switch-offload",
> };
This is definitely not indented properly.
The existing code uses a TAB character, you should too.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ethtool: Add hw-switch-offload to netdev_features_strings.
2015-02-20 22:50 [PATCH net-next] ethtool: Add hw-switch-offload to netdev_features_strings Rami Rosen
2015-02-20 19:09 ` David Miller
@ 2015-02-21 17:31 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2015-02-21 17:31 UTC (permalink / raw)
To: Rami Rosen, davem; +Cc: netdev, roopa
Hello.
On 2/21/2015 1:50 AM, Rami Rosen wrote:
> commit aafb3e98b279 (netdev: introduce new NETIF_F_HW_SWITCH_OFFLOAD feature
> flag for switch device offloads) added a new feature without adding it to
> netdev_features_strings array; this patch fixes this.
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> net/core/ethtool.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index 91f74f3..fc5feda 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -98,6 +98,7 @@ static const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN]
> [NETIF_F_RXALL_BIT] = "rx-all",
> [NETIF_F_HW_L2FW_DOFFLOAD_BIT] = "l2-fwd-offload",
> [NETIF_F_BUSY_POLL_BIT] = "busy-poll",
> + [NETIF_F_HW_SWITCH_OFFLOAD_BIT] = "hw-switch-offload",
Please use tab for the indentation.
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-21 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-20 22:50 [PATCH net-next] ethtool: Add hw-switch-offload to netdev_features_strings Rami Rosen
2015-02-20 19:09 ` David Miller
2015-02-21 17:31 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).