From: Stefan Assmann <sassmann@kpanic.de>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH net-next] i40e: mark constant as ULL
Date: Mon, 23 Feb 2015 15:56:24 +0100 [thread overview]
Message-ID: <54EB3F98.2030709@kpanic.de> (raw)
In-Reply-To: <1423072177.2589.66.camel@jtkirshe-mobl>
On 04.02.2015 18:49, Jeff Kirsher wrote:
> On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
>> This avoids a compile error on 32bit.
>>
>> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
>> ---
>> drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Come to find out, I already have a fix in my queue for this. So I will
> be dropping your patch.
>
> The patch in my queue fixes the issue by doing the folling change:
> - mask = 0xFFFFFFFFFFFFFFFF;
> + mask = ~(u64)0;
>
Jeff,
this does not seem to compile on 32bit either. Please verify and if
you agree let's put my patch back in place instead of this one. IIRC
your patch has not been posted yet.
Stefan
next prev parent reply other threads:[~2015-02-23 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 11:41 [PATCH net-next] i40e: mark constant as ULL Stefan Assmann
2015-02-04 11:59 ` Jeff Kirsher
2015-02-04 17:49 ` Jeff Kirsher
2015-02-05 10:15 ` Stefan Assmann
2015-02-23 14:56 ` Stefan Assmann [this message]
2015-02-24 12:08 ` Stefan Assmann
2015-02-24 12:23 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EB3F98.2030709@kpanic.de \
--to=sassmann@kpanic.de \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).