From: Daniel Borkmann <daniel@iogearbox.net>
To: Madhu Challa <challa@noironetworks.com>,
eric.dumazet@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 1/2] igmp v6: add __ipv6_sock_mc_join and __ipv6_sock_mc_drop
Date: Tue, 24 Feb 2015 11:15:30 +0100 [thread overview]
Message-ID: <54EC4F42.8060702@iogearbox.net> (raw)
In-Reply-To: <1424739550-2691-2-git-send-email-challa@noironetworks.com>
On 02/24/2015 01:59 AM, Madhu Challa wrote:
> Based on the igmp v4 changes from Eric Dumazet.
> 959d10f6bbf6("igmp: add __ip_mc_{join|leave}_group()")
>
> These changes are needed to perform igmp v6 join/leave while
> RTNL is held.
>
> Make ipv6_sock_mc_join and ipv6_sock_mc_drop wrappers around
> __ipv6_sock_mc_join and __ipv6_sock_mc_drop to avoid
> proliferation of work queues.
>
> Signed-off-by: Madhu Challa <challa@noironetworks.com>
...
> @@ -198,25 +197,38 @@ int ipv6_sock_mc_join(struct sock *sk, int ifindex, const struct in6_addr *addr)
> mc_lst->next = np->ipv6_mc_list;
> rcu_assign_pointer(np->ipv6_mc_list, mc_lst);
>
> - rtnl_unlock();
>
Nit: you can also get rid of the newline.
> return 0;
> }
> +EXPORT_SYMBOL(__ipv6_sock_mc_join);
> +
> +int ipv6_sock_mc_join(struct sock *sk, int ifindex, const struct in6_addr *addr)
> +{
Rest looks good to me.
Thanks,
Daniel
next prev parent reply other threads:[~2015-02-24 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 0:59 [PATCH net-next v4 0/2] Multicast group join/leave at ip level Madhu Challa
2015-02-24 0:59 ` [PATCH net-next v4 1/2] igmp v6: add __ipv6_sock_mc_join and __ipv6_sock_mc_drop Madhu Challa
2015-02-24 10:15 ` Daniel Borkmann [this message]
2015-02-24 0:59 ` [PATCH net-next v4 2/2] multicast: Extend ip address command to enable multicast group join/leave on IP level Madhu Challa
2015-02-24 10:13 ` Daniel Borkmann
2015-02-24 18:14 ` Madhu Challa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EC4F42.8060702@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=challa@noironetworks.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).