From: Nikolay Aleksandrov <nikolay@redhat.com>
To: Mahesh Bandewar <maheshb@google.com>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Veaceslav Falico <vfalico@gmail.com>,
David Miller <davem@davemloft.net>
Cc: Maciej Zenczykowski <maze@google.com>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH next 2/2] bonding: Implement port churn-machine (AD standard 43.4.17).
Date: Tue, 24 Feb 2015 18:39:28 +0100 [thread overview]
Message-ID: <54ECB750.3050108@redhat.com> (raw)
In-Reply-To: <1424742611-6698-1-git-send-email-maheshb@google.com>
On 02/24/2015 02:50 AM, Mahesh Bandewar wrote:
> The Churn Detection machines detect the situation where a port is operable,
> but the Actor and Partner have not attached the link to an Aggregator and
> brought the link into operation within a bound time period. Under normal
> operation of the LACP, agreement between Actor and Partner should be reached
> very rapidly. Continued failure to reach agreement can be symptomatic of
> device failure.
>
> Actor-churn-detection state-machine
> ===================================
>
> BEGIN=True + PortEnable=False
> |
> v
> +------------------------+ ActorPort.Sync=True +------------------+
> | ACTOR_CHURN_MONITOR | ---------------------> | NO_ACTOR_CHURN |
> |========================| |==================|
> | ActorChurn=False | ActorPort.Sync=False | ActorChurn=False |
> | ActorChurn.Timer=Start | <--------------------- | |
> +------------------------+ +------------------+
> | ^
> | |
> ActorChurn.Timer=Expired |
> | ActorPort.Sync=True
> | |
> | +-----------------+ |
> | | ACTOR_CHURN | |
> | |=================| |
> +--------------> | ActorChurn=True | ------------+
> | |
> +-----------------+
>
> Similar for the Partner-churn-detection.
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
> ---
> drivers/net/bonding/bond_3ad.c | 57 +++++++++++++++++++++++++++++++++++++--
> drivers/net/bonding/bond_procfs.c | 43 +++++++++++++++++++++++++----
> include/net/bond_3ad.h | 29 ++++++++++++++++++++
> 3 files changed, 122 insertions(+), 7 deletions(-)
>
Reviewed-by: Nikolay Aleksandrov <nikolay@redhat.com>
prev parent reply other threads:[~2015-02-24 17:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 1:50 [PATCH next 2/2] bonding: Implement port churn-machine (AD standard 43.4.17) Mahesh Bandewar
2015-02-24 17:39 ` Nikolay Aleksandrov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ECB750.3050108@redhat.com \
--to=nikolay@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=maheshb@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).