From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH net 2/2] rhashtable: remove indirection for grow/shrink decision functions Date: Wed, 25 Feb 2015 16:46:29 +0100 Message-ID: <54EDEE55.8050605@iogearbox.net> References: <063D6719AE5E284EB5DD2968C1650D6D1CAED36D@AcuExch.aculab.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "tgraf@suug.ch" , "pablo@netfilter.org" , "johunt@akamai.com" , "kaber@trash.net" , "netdev@vger.kernel.org" To: David Laight , "davem@davemloft.net" Return-path: Received: from www62.your-server.de ([213.133.104.62]:53277 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752345AbbBYPqo (ORCPT ); Wed, 25 Feb 2015 10:46:44 -0500 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CAED36D@AcuExch.aculab.com> Sender: netdev-owner@vger.kernel.org List-ID: On 02/25/2015 04:41 PM, David Laight wrote: ... > Why not cache the 'number of items before we need to expand' value > after each expansion, setting it to 'infinite' when expansion is disabled. > Then the above check is a simple comparison. > You probably don't even need an atomic_read() - provided something is > double checked once the first test determines that an expansion is needed. Did you read my cover letter? ;)