netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
To: David Laight <David.Laight@ACULAB.COM>,
	Kalle Valo <kvalo@codeaurora.org>,
	"brudley@broadcom.com" <brudley@broadcom.com>,
	Arend van Spriel <arend@broadcom.com>,
	Franky Lin <frankyl@broadcom.com>,
	"meuleman@broadcom.com" <meuleman@broadcom.com>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"pieterpg@broadcom.com" <pieterpg@broadcom.com>,
	"hdegoede@redhat.com" <hdegoede@redhat.com>,
	"wens@csie.org" <wens@csie.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"brcm80211-dev-list@broadcom.com"
	<brcm80211-dev-list@broadcom.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] brcmfmac: avoid duplicated suspend/resume operation
Date: Fri, 27 Feb 2015 15:42:49 +0800	[thread overview]
Message-ID: <54F01FF9.50108@linux.intel.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CAE430C@AcuExch.aculab.com>


On 2015/2/16 17:50, David Laight wrote:
>>> WiFi chip has 2 SDIO functions, and PM core will trigger
>>> twice suspend/resume operations for one WiFi chip to do
>>> the same things. This patch avoid this case.
> Do you want to suspend on the first or last request?
>
> In general it might be that one function is in use and
> something wants to suspend the other (as inactive).
>
> If they suspend together you might need to pretend the
> first function is suspended but only do the real power-saving
> device suspend when all the functions have been suspended.
I was in Chinese new-year vacation these few days. So sorry for late response.

Suspend/Resume entry functions of brcmfmac driver does not differentiate between two functions, performs the same operations instead.


Thanks,
Zhonghui
>
> 	David
>
> N�����r��y���b�X��ǧv�^�)޺{.n�+����{��*ޕ�,�{ay�\x1dʇڙ�,j\a��f���h���z�\x1e�w���\f���j:+v���w�j�m����\a����zZ+�����ݢj"��!tml=

      reply	other threads:[~2015-02-27  7:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12  3:26 [PATCH v3] brcmfmac: avoid duplicated suspend/resume operation Fu, Zhonghui
     [not found] ` <54DC1D7D.5050407-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-02-15  2:40   ` Fu, Zhonghui
2015-02-15  3:27     ` Pat Erley
     [not found]       ` <54E01209.7010300-Jx9fsTfDDR3YtjvyW6yDsg@public.gmane.org>
2015-02-15  8:31         ` Arend van Spriel
2015-02-15 14:54           ` Kalle Valo
     [not found]             ` <878ufzi5s3.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2015-02-16  7:34               ` Fu, Zhonghui
2015-02-16  9:35                 ` Arend van Spriel
2015-02-27  7:53                   ` Fu, Zhonghui
2015-02-27  9:08                     ` Arend van Spriel
2015-03-02 15:08                       ` Kalle Valo
2015-03-03 19:49                         ` Arend van Spriel
2015-02-16  9:50     ` David Laight
2015-02-27  7:42       ` Fu, Zhonghui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F01FF9.50108@linux.intel.com \
    --to=zhonghui.fu@linux.intel.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=arend@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=brudley@broadcom.com \
    --cc=frankyl@broadcom.com \
    --cc=hdegoede@redhat.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=meuleman@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pieterpg@broadcom.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).