From: Nicolas Schichan <nschichan@freebox.fr>
To: David Miller <davem@davemloft.net>
Cc: tklauser@distanz.ch, balbi@ti.com,
w-lkml@lebenslange-mailadresse.de, ebiederm@xmission.com,
alexander.h.duyck@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcm63xx_enet: fix poll callback.
Date: Tue, 03 Mar 2015 12:18:29 +0100 [thread overview]
Message-ID: <54F59885.1000203@freebox.fr> (raw)
In-Reply-To: <20150302.221547.345365592649851304.davem@davemloft.net>
On 03/03/2015 04:15 AM, David Miller wrote:
> First, no signoff, that is required for your patch.
Hello David,
I realized that I had forgotten the signoff-by line too late unfortunately.
> Secondly, we strongly recommend that TX buffer reclaim be not
> accounted at all in the poll budget.
>
> Just do all of the TX work, unconditionally, every time the poll
> routine is invoked. Do not add it into the work variable that
> gets compared against the budget. Pretend it took '0' units of
> work.
I took inspiration from the mv643xx_eth driver which seems to account the tx
buffer reclaim in the work done in its poll callback. I'll send an updated patch.
Thanks,
--
Nicolas Schichan
Freebox SAS
next prev parent reply other threads:[~2015-03-03 11:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 17:28 [PATCH] bcm63xx_enet: fix poll callback Nicolas Schichan
2015-03-03 3:15 ` David Miller
2015-03-03 11:18 ` Nicolas Schichan [this message]
2015-03-03 19:03 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-03-03 11:45 Nicolas Schichan
2015-03-03 13:29 ` Eric Dumazet
2015-03-03 13:42 ` Eric Dumazet
2015-03-03 13:53 ` Nicolas Schichan
2015-03-03 14:18 ` Eric Dumazet
2015-03-03 14:43 ` Nicolas Schichan
2015-03-03 17:42 ` Florian Fainelli
2015-03-03 23:05 ` Jonas Gorski
2015-03-03 16:09 ` Alexander Duyck
2015-03-03 16:32 ` Eric Dumazet
2015-03-04 20:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F59885.1000203@freebox.fr \
--to=nschichan@freebox.fr \
--cc=alexander.h.duyck@redhat.com \
--cc=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
--cc=w-lkml@lebenslange-mailadresse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).