From: roopa <roopa@cumulusnetworks.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v3] bridge: fix bridge netlink RCU usage
Date: Tue, 03 Mar 2015 06:57:12 -0800 [thread overview]
Message-ID: <54F5CBC8.2000303@cumulusnetworks.com> (raw)
In-Reply-To: <1425394292.2450.47.camel@sipsolutions.net>
On 3/3/15, 6:51 AM, Johannes Berg wrote:
> Hi Roopa,
>
>> My subsequent patch in net-next related to this code, changes things a
>> bit (fed0a159c8c5e453d79d6a73897c576efea0a8a5 bridge: fix link
>> notification skb size calculation to include vlan ranges).
> Yeah, I saw this, but thought the original patch had already gone to
> net.git. Then later I found it hasn't but didn't remember ... sorry
> about that.
>
>> It reverts the use of this function which makes sure this is always
>> called under rtnl.
>> But, I did add another version of this function in net-next which has
>> the same problem.
>> Assuming that patch in net-next is on its way to net soon, am wondering
>> if fixing it in net-next is the right course.
> Of course, this patch should then only ever be applied to net-next.
>
>> I can apply your patch there and re-submit. Or if you prefer to
>> re-submit your patch on net-next that's great too.
> I can resend it. I even have a pretty simple test case to reproduce the
> failure :)
>
great!. Thank you.
prev parent reply other threads:[~2015-03-03 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 13:49 [PATCH v3] bridge: fix bridge netlink RCU usage Johannes Berg
2015-03-03 14:31 ` roopa
2015-03-03 14:51 ` Johannes Berg
2015-03-03 14:57 ` roopa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5CBC8.2000303@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).