[PATCH -next] net: i40e: fix build, depends on CONFIGFS_FS

[PATCH -next] net: i40e: fix build, depends on CONFIGFS_FS

[Randy Dunlap]

From: Randy Dunlap <rdunlap@infradead.org>

i40e uses configfs interfaces so it should depend on CONFIGFS_FS.

Fixes these build errors:

drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
i40e_configfs.c:(.text+0x2fcdca): undefined reference to `config_item_init_type_name'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x2fcee6): undefined reference to `config_group_init'
drivers/built-in.o: In function `i40e_configfs_init':
(.text+0x2fcf0c): undefined reference to `configfs_register_subsystem'
drivers/built-in.o: In function `i40e_configfs_exit':
(.text+0x2fcf71): undefined reference to `configfs_unregister_subsystem'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc:	Linux NICS <linux.nics@intel.com>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20150303.orig/drivers/net/ethernet/intel/Kconfig
+++ linux-next-20150303/drivers/net/ethernet/intel/Kconfig
@@ -256,6 +256,7 @@ config I40E
 	tristate "Intel(R) Ethernet Controller XL710 Family support"
 	select PTP_1588_CLOCK
 	depends on PCI
+	depends on CONFIGFS_FS
 	---help---
 	  This driver supports Intel(R) Ethernet Controller XL710 Family of
 	  devices.  For more information on how to identify your adapter, go

Re: [PATCH -next] net: i40e: fix build, depends on CONFIGFS_FS

[David Miller]

From: Randy Dunlap <rdunlap@infradead.org>
Date: Tue, 03 Mar 2015 11:35:38 -0800

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> i40e uses configfs interfaces so it should depend on CONFIGFS_FS.
> 
> Fixes these build errors:
> 
> drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
> i40e_configfs.c:(.text+0x2fcdca): undefined reference to `config_item_init_type_name'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x2fcee6): undefined reference to `config_group_init'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x2fcf0c): undefined reference to `configfs_register_subsystem'
> drivers/built-in.o: In function `i40e_configfs_exit':
> (.text+0x2fcf71): undefined reference to `configfs_unregister_subsystem'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Intel guys, I am furiously mad.

I've told you guys a thousand times to use portable, reasonable
mechanisms to configure your hardware.  Using facilities that can
be used for other cards from other vendors with similar facilities.

If such portable netdevice configuration frameworks do not exist,
create it.

Every time you make a device specific mechanism for configuration,
a small kitten dies somewhere in the world.

Please remove all of this configfs crap for twiddling bandwidth
et al. knobs, before I do it for you.

Thanks.

Re: [PATCH -next] net: i40e: fix build, depends on CONFIGFS_FS

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

On Tue, 2015-03-03 at 11:35 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> i40e uses configfs interfaces so it should depend on CONFIGFS_FS.
> 
> Fixes these build errors:
> 
> drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
> i40e_configfs.c:(.text+0x2fcdca): undefined reference to
> `config_item_init_type_name'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x2fcee6): undefined reference to `config_group_init'
> drivers/built-in.o: In function `i40e_configfs_init':
> (.text+0x2fcf0c): undefined reference to `configfs_register_subsystem'
> drivers/built-in.o: In function `i40e_configfs_exit':
> (.text+0x2fcf71): undefined reference to
> `configfs_unregister_subsystem'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc:     Linux NICS <linux.nics@intel.com>
> Cc:     Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
>  drivers/net/ethernet/intel/Kconfig |    1 +
>  1 file changed, 1 insertion(+)

I have a patch from Greg Rose already that fixes this, which I was just
about to push.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH -next] net: i40e: fix build, depends on CONFIGFS_FS

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]

On Tue, 2015-03-03 at 15:02 -0500, David Miller wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> Date: Tue, 03 Mar 2015 11:35:38 -0800
> 
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > i40e uses configfs interfaces so it should depend on CONFIGFS_FS.
> > 
> > Fixes these build errors:
> > 
> > drivers/built-in.o: In function `i40e_cfgfs_group_make_item':
> > i40e_configfs.c:(.text+0x2fcdca): undefined reference to `config_item_init_type_name'
> > drivers/built-in.o: In function `i40e_configfs_init':
> > (.text+0x2fcee6): undefined reference to `config_group_init'
> > drivers/built-in.o: In function `i40e_configfs_init':
> > (.text+0x2fcf0c): undefined reference to `configfs_register_subsystem'
> > drivers/built-in.o: In function `i40e_configfs_exit':
> > (.text+0x2fcf71): undefined reference to `configfs_unregister_subsystem'
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Intel guys, I am furiously mad.
> 
> I've told you guys a thousand times to use portable, reasonable
> mechanisms to configure your hardware.  Using facilities that can
> be used for other cards from other vendors with similar facilities.
> 
> If such portable netdevice configuration frameworks do not exist,
> create it.
> 
> Every time you make a device specific mechanism for configuration,
> a small kitten dies somewhere in the world.
> 
> Please remove all of this configfs crap for twiddling bandwidth
> et al. knobs, before I do it for you.

Sorry Dave, I did not see the configfs changes as being in the same boat
as some of the debugfs changes which were unacceptable.

I am working with Greg Rose and Jesse Brandeburg to address your
concerns with these recent changes.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]