netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.h.duyck@redhat.com>
To: Dave Taht <dave.taht@gmail.com>, Scott Feldman <sfeldma@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>
Subject: Re: I can tell no FIB
Date: Thu, 05 Mar 2015 15:44:33 -0800	[thread overview]
Message-ID: <54F8EA61.9010706@redhat.com> (raw)
In-Reply-To: <CAA93jw5oMK-KC-EkG71LKThqQxsHYcft+OHuu=APzjLdWSuO4g@mail.gmail.com>


On 03/05/2015 01:01 PM, Dave Taht wrote:
> On Thu, Mar 5, 2015 at 12:49 PM, Scott Feldman <sfeldma@gmail.com> wrote:
>> Hi Alex, turns out you're required to take a mandatory week-long
>> vacation after your fourth patch set to net/ipv4/fib_*.  See you in a
>> week!  Take lots of pictures.
> +10!
>
> Is anyone here working on testing the new FIB stuff on itty bitty 32
> bit platforms? It looks really promising
> but openwrt is stabilizing on 3.18 and the prospect of backporting all
> this stuff to that to test at scale is intimidating. (*I* am willing
> to wait for 4.2)
>
> But boy, could openwrt test at scale:
>
> https://downloads.openwrt.org/snapshots/trunk/

As far as what to backport I would recommend only targeting the FIB 
changes that went into 4.0.  It was low risk for causing regressions and 
significant benefit.  This is why I referred to them as "low hanging 
fruit" when I described them  in my presentation at Netdev 0.1.  The 
stuff that went into 4.0 reduced things by hundreds of nanosecnds in 
some cases, the stuff targeting net-next/4.1 is only going to reduce 
things by tens of nanoseconds.

What I am working on now is basically just trying squeeze the last bits 
of performance out of what is left.    Excluding the main/local merge I 
have been able to remove 20% (10 - 35ns depending on the test) of the 
remaining CPU overhead for the fib table look-up with what has been 
submitted since net-next reopened.  The local/main trie merge pushes 
that to somewhere around a 40% reduction from what I have seen.

- Alex

  reply	other threads:[~2015-03-05 23:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05 20:49 I can tell no FIB Scott Feldman
2015-03-05 21:01 ` Dave Taht
2015-03-05 23:44   ` Alexander Duyck [this message]
2015-03-05 21:17 ` Alexander Duyck
2015-03-05 21:27   ` David Miller
2015-03-05 22:01     ` Alexander Duyck
2015-03-06  0:07       ` Scott Feldman
2015-03-06  0:20         ` Alexander Duyck
2015-03-06  3:20           ` David Miller
2015-03-06  5:34             ` Scott Feldman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F8EA61.9010706@redhat.com \
    --to=alexander.h.duyck@redhat.com \
    --cc=dave.taht@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).