From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: <monstr@monstr.eu>, Michal Simek <michal.simek@xilinx.com>,
<linux-kernel@vger.kernel.org>
Cc: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH 1/2] net: macb: Include multi queue support for xilinx ZynqMP ethernet version
Date: Fri, 6 Mar 2015 17:48:49 +0100 [thread overview]
Message-ID: <54F9DA71.804@atmel.com> (raw)
In-Reply-To: <54F86171.3020700@monstr.eu>
Le 05/03/2015 15:00, Michal Simek a écrit :
> Hi Nicolas,
>
> On 03/05/2015 02:04 PM, Michal Simek wrote:
>> From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>
>>
>> Include multi queue support for the ethernet IP version in xilinx ZynqMP
>> SoC.
>>
>> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> drivers/net/ethernet/cadence/macb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
>> index ad76b8e35a00..24b1eb466e52 100644
>> --- a/drivers/net/ethernet/cadence/macb.c
>> +++ b/drivers/net/ethernet/cadence/macb.c
>> @@ -2192,7 +2192,7 @@ static void macb_probe_queues(void __iomem *mem,
>>
>> /* is it macb or gem ? */
>> mid = __raw_readl(mem + MACB_MID);
>> - if (MACB_BFEXT(IDNUM, mid) != 0x2)
>> + if (MACB_BFEXT(IDNUM, mid) < 0x2)
>> return;
>>
>> /* bit 0 is never set but queue 0 always exists */
>>
>
> Can you please check this?
> (There will be definitely v2 because I forget to base it on net-next).
Michal,
It seems correct to me: you can add my:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Bye,
--
Nicolas Ferre
prev parent reply other threads:[~2015-03-06 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 13:04 [PATCH 1/2] net: macb: Include multi queue support for xilinx ZynqMP ethernet version Michal Simek
2015-03-05 13:04 ` [PATCH 2/2] net: macb: Fix multi queue support for xilinx ZynqMP soc Michal Simek
2015-03-06 16:55 ` Nicolas Ferre
2015-03-05 14:00 ` [PATCH 1/2] net: macb: Include multi queue support for xilinx ZynqMP ethernet version Michal Simek
2015-03-06 16:48 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F9DA71.804@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=punnaiah.choudary.kalluri@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).