From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Michal Simek <michal.simek@xilinx.com>,
<linux-kernel@vger.kernel.org>, <monstr@monstr.eu>
Cc: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] net: macb: Fix multi queue support for xilinx ZynqMP soc
Date: Fri, 6 Mar 2015 17:55:23 +0100 [thread overview]
Message-ID: <54F9DBFB.3020504@atmel.com> (raw)
In-Reply-To: <364d36c03e63ef33c5f52a8eaa4418320c6c0d3f.1425560649.git.michal.simek@xilinx.com>
Le 05/03/2015 14:04, Michal Simek a écrit :
> From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>
>
> ZynqMP soc has single interrupt for all the queue events. So,
> passing the IRQF_SHARED flag for interrupt registration call.
>
> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Ok then:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
>
> drivers/net/ethernet/cadence/macb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 24b1eb466e52..0493c3e6bbbe 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -2319,7 +2319,7 @@ static int macb_probe(struct platform_device *pdev)
> */
> queue->irq = platform_get_irq(pdev, q);
> err = devm_request_irq(&pdev->dev, queue->irq, macb_interrupt,
> - 0, dev->name, queue);
> + IRQF_SHARED, dev->name, queue);
> if (err) {
> dev_err(&pdev->dev,
> "Unable to request IRQ %d (error %d)\n",
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-03-06 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 13:04 [PATCH 1/2] net: macb: Include multi queue support for xilinx ZynqMP ethernet version Michal Simek
2015-03-05 13:04 ` [PATCH 2/2] net: macb: Fix multi queue support for xilinx ZynqMP soc Michal Simek
2015-03-06 16:55 ` Nicolas Ferre [this message]
2015-03-05 14:00 ` [PATCH 1/2] net: macb: Include multi queue support for xilinx ZynqMP ethernet version Michal Simek
2015-03-06 16:48 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F9DBFB.3020504@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=punnaiah.choudary.kalluri@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).