From: Jonathan Toppins <jtoppins@cumulusnetworks.com>
To: sfeldma@gmail.com, netdev@vger.kernel.org
Cc: jiri@resnulli.us
Subject: Re: [PATCH net-next 1/2] rocker: quiet sparce endianess warnings
Date: Fri, 06 Mar 2015 19:21:38 -0500 [thread overview]
Message-ID: <54FA4492.4080809@cumulusnetworks.com> (raw)
In-Reply-To: <1425686092-2836-1-git-send-email-sfeldma@gmail.com>
On 3/6/15 6:54 PM, sfeldma@gmail.com wrote:
subject spelling s/sparce/sparse/
> From: Scott Feldman <sfeldma@gmail.com>
>
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Reviewed-by: Jonathan Toppins <jtoppins@cumulusnetworks.com>
> ---
> drivers/net/ethernet/rocker/rocker.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
> index cc1bbfd..9629352 100644
> --- a/drivers/net/ethernet/rocker/rocker.c
> +++ b/drivers/net/ethernet/rocker/rocker.c
> @@ -2737,7 +2737,8 @@ static struct rocker_neigh_tbl_entry *
> {
> struct rocker_neigh_tbl_entry *found;
>
> - hash_for_each_possible(rocker->neigh_tbl, found, entry, (u32)ip_addr)
> + hash_for_each_possible(rocker->neigh_tbl, found,
> + entry, be32_to_cpu(ip_addr))
> if (found->ip_addr == ip_addr)
> return found;
>
> @@ -2749,7 +2750,8 @@ static void _rocker_neigh_add(struct rocker *rocker,
> {
> entry->index = rocker->neigh_tbl_next_index++;
> entry->ref_count++;
> - hash_add(rocker->neigh_tbl, &entry->entry, (u32)entry->ip_addr);
> + hash_add(rocker->neigh_tbl, &entry->entry,
> + be32_to_cpu(entry->ip_addr));
> }
>
> static void _rocker_neigh_del(struct rocker *rocker,
> @@ -2868,7 +2870,7 @@ static int rocker_port_ipv4_resolve(struct rocker_port *rocker_port,
> __be32 ip_addr)
> {
> struct net_device *dev = rocker_port->dev;
> - struct neighbour *n = __ipv4_neigh_lookup(dev, (u32)ip_addr);
> + struct neighbour *n = __ipv4_neigh_lookup(dev, (__force u32)ip_addr);
> int err = 0;
>
> if (!n)
>
next prev parent reply other threads:[~2015-03-07 0:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 23:54 [PATCH net-next 1/2] rocker: quiet sparce endianess warnings sfeldma
2015-03-06 23:54 ` [PATCH net-next 2/2] rocker: sparse: fix dynamic allocation on stack warning sfeldma
2015-03-07 3:02 ` David Miller
2015-03-07 0:21 ` Jonathan Toppins [this message]
2015-03-07 3:02 ` [PATCH net-next 1/2] rocker: quiet sparce endianess warnings David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FA4492.4080809@cumulusnetworks.com \
--to=jtoppins@cumulusnetworks.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).