netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: roopa <roopa@cumulusnetworks.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: sfeldma@gmail.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] bond: add support for ndo_switch_port_stp_update when bond is a bridge port
Date: Fri, 06 Mar 2015 22:56:48 -0800	[thread overview]
Message-ID: <54FAA130.6050800@cumulusnetworks.com> (raw)
In-Reply-To: <20150306065542.GB2004@nanopsycho.orion>

On 3/5/15, 10:55 PM, Jiri Pirko wrote:
> Fri, Mar 06, 2015 at 05:04:17AM CET, roopa@cumulusnetworks.com wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> This patch adds support for stp state offload netdev op to support the case
>> where bond is a bridge port and bond slaves are switch ports.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> Maybe the indent should be fixed for the rest to align with
> .ndo_switch_port_stp_update. Not sure if that is needed thought. The
> same note goes for team.
Thanks Jiri. I looked at it and you are right i am not sure i can do 
anything more.
>
> Acked-by: Jiri Pirko <jiri@resnulli.us>
>
>> ---
>> drivers/net/bonding/bond_main.c |    1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>> index 675b082..bf60535 100644
>> --- a/drivers/net/bonding/bond_main.c
>> +++ b/drivers/net/bonding/bond_main.c
>> @@ -4005,6 +4005,7 @@ static const struct net_device_ops bond_netdev_ops = {
>> 	.ndo_fix_features	= bond_fix_features,
>> 	.ndo_bridge_setlink	= ndo_dflt_netdev_switch_port_bridge_setlink,
>> 	.ndo_bridge_dellink	= ndo_dflt_netdev_switch_port_bridge_dellink,
>> +	.ndo_switch_port_stp_update = ndo_dflt_netdev_switch_port_stp_update,
>> };
>>
>> static const struct device_type bond_type = {
>> -- 
>> 1.7.10.4
>>

      reply	other threads:[~2015-03-07  6:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06  4:04 [PATCH net-next 2/3] bond: add support for ndo_switch_port_stp_update when bond is a bridge port roopa
2015-03-06  6:55 ` Jiri Pirko
2015-03-07  6:56   ` roopa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FAA130.6050800@cumulusnetworks.com \
    --to=roopa@cumulusnetworks.com \
    --cc=davem@davemloft.net \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=sfeldma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).