From: Jeff Kirsher <tarbal@gmail.com>
To: Or Gerlitz <gerlitz.or@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "vyasevic@redhat.com" <vyasevic@redhat.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"Choi, Sy Jong" <sy.jong.choi@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David Laight" <David.Laight@aculab.com>,
"Hayato Momma" <h-momma@ce.jp.nec.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Edward Cree" <ecree@solarflare.com>,
"Hiroshi Shimamoto" <h-shimamoto@ct.jp.nec.com>,
"Bjørn Mork" <bjorn@mork.no>
Subject: Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control
Date: Mon, 09 Mar 2015 00:27:14 -0700 [thread overview]
Message-ID: <54FD4B52.6010100@gmail.com> (raw)
In-Reply-To: <CAJ3xEMjNKJFps7C2jsuFfnSn8pDtkCTtEhuQz8s+f=euR5=BXA@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 03/08/2015 02:15 PM, Or Gerlitz wrote:
> On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher
> <jeffrey.t.kirsher@intel.com> wrote:
> [...]
>> We discussed this during NetConf last week, and Don is correct that a
>> custom sysfs interface is not the way we want to handle this. We agreed
>> upon a generic interface so that any NIC is able to turn on or off VF
>> multicast promiscuous mode.
>
> Jeff, please make sure to either respond to my comments on the V2
> thread (or better) address them for the V3 post.
>
>
> http://marc.info/?l=linux-netdev&m=142441852518152&w=2
> http://marc.info/?l=linux-netdev&m=142441867218183&w=2
I agree with you that the patch descriptions should be cleaned up and
"beefed" up for that matter.
If/when I look to push his series of patches, I will make sure that your
concerns are addressed so that we can get a accurate changelog.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCgAGBQJU/UtSAAoJEOVv75VaS+3On0kP/3P+DkiCmset60z9Ms6MpqHZ
/J06eJpplGXz/TnKF1wTrOxgV+LV750q4J0IXkd/kbj23sC5SOnsxHlMWdb4SFWk
OW2vcB1HEqug7xCi9FukJzaORSfH1hWeSNtEuvKtjOREVLTCSZWkEyYE0SMJTU7N
ISaQtFlkOXomtZbri//M6XBVxW+DFyrEhjZgPl7HY+x2nZIXWh8NwI5kp7zYst2S
mWbNUIi8lJEHWbhF0MBG+QGSoND6zeKGJ5JWjp3ml40a4DNmAs4cVftsV7wvir8/
+QITHejBkIboZe8C7YrTNGN2qfzQfMsRRzdAaQW4Q4pr5MQcwAKEN/iHoG/jBik2
y00xJ6pf7v8ogNs72oJ24tFnp93H1nusIXG1oWVo+cwLwkDbGS0oLYs/5r6bMk+7
Z4JVieh0gcbeIFF7i3ZVOSKFcUVSFf5Kvw0isY7nnefyrhSJ1jQbP3i8ABVrH2fN
zO06JSARwu797r78292eXyGe74bE4LGmIHbwGKDP/Mz/1DP+Qafk+mEllQIxSFel
ODQSAjOQZTnP9KZ+t2XUdLnImlaKPnfjtMjdEny678/fmcZh1zjAHLTn4gmrA9vq
otKjWCS3cA6UVCyn+ph8+2sHtRLW6w7pQ7BcIXLTlaPp/gC97f3eHxvRN4nV1vA5
c+gQPJx98sCiBd3gFKX0
=9V5M
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2015-03-09 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 21:15 [PATCH v2 2/3] if_link: Add VF multicast promiscuous control Or Gerlitz
2015-03-09 7:27 ` Jeff Kirsher [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-03-10 1:42 Hiroshi Shimamoto
2015-03-10 1:52 ` Jeff Kirsher
2015-03-10 2:48 ` [E1000-devel] " Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FD4B52.6010100@gmail.com \
--to=tarbal@gmail.com \
--cc=David.Laight@aculab.com \
--cc=bjorn@mork.no \
--cc=e1000-devel@lists.sourceforge.net \
--cc=ecree@solarflare.com \
--cc=gerlitz.or@gmail.com \
--cc=h-momma@ce.jp.nec.com \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sy.jong.choi@intel.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).