* [PATCH] net: can: Enable xilinx driver for all ARCHs @ 2015-03-09 8:48 Michal Simek 2015-03-09 8:50 ` Marc Kleine-Budde 0 siblings, 1 reply; 11+ messages in thread From: Michal Simek @ 2015-03-09 8:48 UTC (permalink / raw) To: linux-kernel, monstr Cc: Wolfgang Grandegger, Marc Kleine-Budde, linux-can, netdev Remove Kconfig dependency and enable driver for all ARCHs. Signed-off-by: Michal Simek <michal.simek@xilinx.com> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> --- Test for all archs done by Kbuild test robot without any problem. --- drivers/net/can/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index 98d73aab52fe..f690c3fb3088 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig @@ -131,7 +131,6 @@ config CAN_RCAR config CAN_XILINXCAN tristate "Xilinx CAN" - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST depends on COMMON_CLK && HAS_IOMEM ---help--- Xilinx CAN driver. This driver supports both soft AXI CAN IP and -- 1.8.2.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] net: can: Enable xilinx driver for all ARCHs 2015-03-09 8:48 [PATCH] net: can: Enable xilinx driver for all ARCHs Michal Simek @ 2015-03-09 8:50 ` Marc Kleine-Budde 2015-03-09 8:58 ` Michal Simek 0 siblings, 1 reply; 11+ messages in thread From: Marc Kleine-Budde @ 2015-03-09 8:50 UTC (permalink / raw) To: Michal Simek, linux-kernel, monstr; +Cc: Wolfgang Grandegger, linux-can, netdev [-- Attachment #1: Type: text/plain, Size: 1046 bytes --] On 03/09/2015 09:48 AM, Michal Simek wrote: > Remove Kconfig dependency and enable driver for > all ARCHs. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> > --- > > Test for all archs done by Kbuild test robot without any problem. > --- > drivers/net/can/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig > index 98d73aab52fe..f690c3fb3088 100644 > --- a/drivers/net/can/Kconfig > +++ b/drivers/net/can/Kconfig > @@ -131,7 +131,6 @@ config CAN_RCAR > > config CAN_XILINXCAN > tristate "Xilinx CAN" > - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST I think that's what COMPILE_TEST ist for? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] net: can: Enable xilinx driver for all ARCHs 2015-03-09 8:50 ` Marc Kleine-Budde @ 2015-03-09 8:58 ` Michal Simek 2015-03-09 9:13 ` Marc Kleine-Budde 0 siblings, 1 reply; 11+ messages in thread From: Michal Simek @ 2015-03-09 8:58 UTC (permalink / raw) To: Marc Kleine-Budde, Michal Simek, linux-kernel, monstr Cc: Wolfgang Grandegger, linux-can, netdev [-- Attachment #1: Type: text/plain, Size: 1149 bytes --] On 03/09/2015 09:50 AM, Marc Kleine-Budde wrote: > On 03/09/2015 09:48 AM, Michal Simek wrote: >> Remove Kconfig dependency and enable driver for >> all ARCHs. >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> >> --- >> >> Test for all archs done by Kbuild test robot without any problem. >> --- >> drivers/net/can/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig >> index 98d73aab52fe..f690c3fb3088 100644 >> --- a/drivers/net/can/Kconfig >> +++ b/drivers/net/can/Kconfig >> @@ -131,7 +131,6 @@ config CAN_RCAR >> >> config CAN_XILINXCAN >> tristate "Xilinx CAN" >> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST > > I think that's what COMPILE_TEST ist for? For compilation yes but not for enabling. Currently this driver can be also used on ARM64 that's why people suggesting directly to remove dependency on arch and then COMPILE_TEST can be removed too. Or do you want me to change description to mention that this is for ARM64 enabling? Thanks, Michal [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] net: can: Enable xilinx driver for all ARCHs 2015-03-09 8:58 ` Michal Simek @ 2015-03-09 9:13 ` Marc Kleine-Budde 2015-03-09 9:52 ` Michal Simek 0 siblings, 1 reply; 11+ messages in thread From: Marc Kleine-Budde @ 2015-03-09 9:13 UTC (permalink / raw) To: Michal Simek, linux-kernel, monstr Cc: Wolfgang Grandegger, linux-can, netdev, Jean Delvare [-- Attachment #1: Type: text/plain, Size: 1811 bytes --] On 03/09/2015 09:58 AM, Michal Simek wrote: > On 03/09/2015 09:50 AM, Marc Kleine-Budde wrote: >> On 03/09/2015 09:48 AM, Michal Simek wrote: >>> Remove Kconfig dependency and enable driver for >>> all ARCHs. >>> >>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> >>> --- >>> >>> Test for all archs done by Kbuild test robot without any problem. >>> --- >>> drivers/net/can/Kconfig | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig >>> index 98d73aab52fe..f690c3fb3088 100644 >>> --- a/drivers/net/can/Kconfig >>> +++ b/drivers/net/can/Kconfig >>> @@ -131,7 +131,6 @@ config CAN_RCAR >>> >>> config CAN_XILINXCAN >>> tristate "Xilinx CAN" >>> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST >> >> I think that's what COMPILE_TEST ist for? > > For compilation yes but not for enabling. Currently this driver > can be also used on ARM64 that's why people suggesting directly > to remove dependency on arch and then COMPILE_TEST can be removed > too. In the past (May 2014) I had people complaining that certain ARM SoC specific drivers are enabled on ARM in general, not just on that SoC. As I'm not following arm64 in detail, has the notion of using depends on ARCH changes since then? > Or do you want me to change description to mention that this is for > ARM64 enabling? Given this is consensus, a remark to ARM64 would be appreciated. :) Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] net: can: Enable xilinx driver for all ARCHs 2015-03-09 9:13 ` Marc Kleine-Budde @ 2015-03-09 9:52 ` Michal Simek 2015-03-09 9:56 ` Marc Kleine-Budde 0 siblings, 1 reply; 11+ messages in thread From: Michal Simek @ 2015-03-09 9:52 UTC (permalink / raw) To: Marc Kleine-Budde, Michal Simek, linux-kernel, monstr Cc: Wolfgang Grandegger, linux-can, netdev, Jean Delvare [-- Attachment #1: Type: text/plain, Size: 2156 bytes --] On 03/09/2015 10:13 AM, Marc Kleine-Budde wrote: > On 03/09/2015 09:58 AM, Michal Simek wrote: >> On 03/09/2015 09:50 AM, Marc Kleine-Budde wrote: >>> On 03/09/2015 09:48 AM, Michal Simek wrote: >>>> Remove Kconfig dependency and enable driver for >>>> all ARCHs. >>>> >>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> >>>> --- >>>> >>>> Test for all archs done by Kbuild test robot without any problem. >>>> --- >>>> drivers/net/can/Kconfig | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig >>>> index 98d73aab52fe..f690c3fb3088 100644 >>>> --- a/drivers/net/can/Kconfig >>>> +++ b/drivers/net/can/Kconfig >>>> @@ -131,7 +131,6 @@ config CAN_RCAR >>>> >>>> config CAN_XILINXCAN >>>> tristate "Xilinx CAN" >>>> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST >>> >>> I think that's what COMPILE_TEST ist for? >> >> For compilation yes but not for enabling. Currently this driver >> can be also used on ARM64 that's why people suggesting directly >> to remove dependency on arch and then COMPILE_TEST can be removed >> too. > > In the past (May 2014) I had people complaining that certain ARM SoC > specific drivers are enabled on ARM in general, not just on that SoC. As > I'm not following arm64 in detail, has the notion of using depends on > ARCH changes since then? > >> Or do you want me to change description to mention that this is for >> ARM64 enabling? > > Given this is consensus, a remark to ARM64 would be appreciated. :) David has applied this patch which is in general just the same as this one. (linux-next) Remove architecture dependency 28811a8c00fe0d899b8a544421f3b4947425d5e8 Mark Brown has suggested to do so for spi and don't check architecture at all. I have also sent similar patch for watchdog driver too. I think it is up to you if you want to add ARM64 to Kconfig or just remove that arch dependencies. To be honest my goal is to enable this driver for ARM64. Please tell me what way you prefer. Thanks, Michal [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] net: can: Enable xilinx driver for all ARCHs 2015-03-09 9:52 ` Michal Simek @ 2015-03-09 9:56 ` Marc Kleine-Budde 2015-03-09 13:53 ` Jean Delvare 0 siblings, 1 reply; 11+ messages in thread From: Marc Kleine-Budde @ 2015-03-09 9:56 UTC (permalink / raw) To: Michal Simek, linux-kernel, monstr Cc: Wolfgang Grandegger, linux-can, netdev, Jean Delvare [-- Attachment #1: Type: text/plain, Size: 2628 bytes --] On 03/09/2015 10:52 AM, Michal Simek wrote: > On 03/09/2015 10:13 AM, Marc Kleine-Budde wrote: >> On 03/09/2015 09:58 AM, Michal Simek wrote: >>> On 03/09/2015 09:50 AM, Marc Kleine-Budde wrote: >>>> On 03/09/2015 09:48 AM, Michal Simek wrote: >>>>> Remove Kconfig dependency and enable driver for >>>>> all ARCHs. >>>>> >>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>>> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> >>>>> --- >>>>> >>>>> Test for all archs done by Kbuild test robot without any problem. >>>>> --- >>>>> drivers/net/can/Kconfig | 1 - >>>>> 1 file changed, 1 deletion(-) >>>>> >>>>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig >>>>> index 98d73aab52fe..f690c3fb3088 100644 >>>>> --- a/drivers/net/can/Kconfig >>>>> +++ b/drivers/net/can/Kconfig >>>>> @@ -131,7 +131,6 @@ config CAN_RCAR >>>>> >>>>> config CAN_XILINXCAN >>>>> tristate "Xilinx CAN" >>>>> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST >>>> >>>> I think that's what COMPILE_TEST ist for? >>> >>> For compilation yes but not for enabling. Currently this driver >>> can be also used on ARM64 that's why people suggesting directly >>> to remove dependency on arch and then COMPILE_TEST can be removed >>> too. >> >> In the past (May 2014) I had people complaining that certain ARM SoC >> specific drivers are enabled on ARM in general, not just on that SoC. As >> I'm not following arm64 in detail, has the notion of using depends on >> ARCH changes since then? >> >>> Or do you want me to change description to mention that this is for >>> ARM64 enabling? >> >> Given this is consensus, a remark to ARM64 would be appreciated. :) > > David has applied this patch which is in general just the same as this one. > > (linux-next) Remove architecture dependency > 28811a8c00fe0d899b8a544421f3b4947425d5e8 > > Mark Brown has suggested to do so for spi and don't check architecture at > all. > I have also sent similar patch for watchdog driver too. > > I think it is up to you if you want to add ARM64 to Kconfig or just remove > that arch dependencies. > To be honest my goal is to enable this driver for ARM64. > Please tell me what way you prefer. I like the idea of removing the depends on ARCH completely. Jean, what do you think? regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] net: can: Enable xilinx driver for all ARCHs 2015-03-09 9:56 ` Marc Kleine-Budde @ 2015-03-09 13:53 ` Jean Delvare 2015-03-09 13:55 ` Marc Kleine-Budde 0 siblings, 1 reply; 11+ messages in thread From: Jean Delvare @ 2015-03-09 13:53 UTC (permalink / raw) To: Marc Kleine-Budde Cc: Michal Simek, linux-kernel, monstr, Wolfgang Grandegger, linux-can, netdev Le Monday 09 March 2015 à 10:56 +0100, Marc Kleine-Budde a écrit : > On 03/09/2015 10:52 AM, Michal Simek wrote: > > On 03/09/2015 10:13 AM, Marc Kleine-Budde wrote: > >> On 03/09/2015 09:58 AM, Michal Simek wrote: > >>> On 03/09/2015 09:50 AM, Marc Kleine-Budde wrote: > >>>> On 03/09/2015 09:48 AM, Michal Simek wrote: > >>>>> Remove Kconfig dependency and enable driver for > >>>>> all ARCHs. > >>>>> > >>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > >>>>> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> > >>>>> --- > >>>>> > >>>>> Test for all archs done by Kbuild test robot without any problem. > >>>>> --- > >>>>> drivers/net/can/Kconfig | 1 - > >>>>> 1 file changed, 1 deletion(-) > >>>>> > >>>>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig > >>>>> index 98d73aab52fe..f690c3fb3088 100644 > >>>>> --- a/drivers/net/can/Kconfig > >>>>> +++ b/drivers/net/can/Kconfig > >>>>> @@ -131,7 +131,6 @@ config CAN_RCAR > >>>>> > >>>>> config CAN_XILINXCAN > >>>>> tristate "Xilinx CAN" > >>>>> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST > >>>> > >>>> I think that's what COMPILE_TEST ist for? > >>> > >>> For compilation yes but not for enabling. Currently this driver > >>> can be also used on ARM64 that's why people suggesting directly > >>> to remove dependency on arch and then COMPILE_TEST can be removed > >>> too. > >> > >> In the past (May 2014) I had people complaining that certain ARM SoC > >> specific drivers are enabled on ARM in general, not just on that SoC. As > >> I'm not following arm64 in detail, has the notion of using depends on > >> ARCH changes since then? > >> > >>> Or do you want me to change description to mention that this is for > >>> ARM64 enabling? > >> > >> Given this is consensus, a remark to ARM64 would be appreciated. :) > > > > David has applied this patch which is in general just the same as this one. > > > > (linux-next) Remove architecture dependency > > 28811a8c00fe0d899b8a544421f3b4947425d5e8 > > > > Mark Brown has suggested to do so for spi and don't check architecture at > > all. > > I have also sent similar patch for watchdog driver too. > > > > I think it is up to you if you want to add ARM64 to Kconfig or just remove > > that arch dependencies. > > To be honest my goal is to enable this driver for ARM64. > > Please tell me what way you prefer. > > I like the idea of removing the depends on ARCH completely. Jean, what > do you think? Removing the dependency completely will let the option be displayed on systems where the driver is useless. I am in favor of having hardware dependencies on as many drivers as possible to avoid bothering the user with irrelevant questions. The list of Kconfig entries has grown a lot over time! If the current dependency is too strict then I would suggest to extend it or to make it broader (depends on ARM || ARM64 || COMPILE_TEST would be acceptable IMHO.) Dropping it completely only makes sense if the part is used on so many systems that the dependency becomes too long or is a pain to maintain. Thanks, -- Jean Delvare SUSE L3 Support ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] net: can: Enable xilinx driver for all ARCHs 2015-03-09 13:53 ` Jean Delvare @ 2015-03-09 13:55 ` Marc Kleine-Budde 2015-03-09 14:04 ` Michal Simek 0 siblings, 1 reply; 11+ messages in thread From: Marc Kleine-Budde @ 2015-03-09 13:55 UTC (permalink / raw) To: Jean Delvare Cc: Michal Simek, linux-kernel, monstr, Wolfgang Grandegger, linux-can, netdev [-- Attachment #1: Type: text/plain, Size: 3534 bytes --] On 03/09/2015 02:53 PM, Jean Delvare wrote: > Le Monday 09 March 2015 à 10:56 +0100, Marc Kleine-Budde a écrit : >> On 03/09/2015 10:52 AM, Michal Simek wrote: >>> On 03/09/2015 10:13 AM, Marc Kleine-Budde wrote: >>>> On 03/09/2015 09:58 AM, Michal Simek wrote: >>>>> On 03/09/2015 09:50 AM, Marc Kleine-Budde wrote: >>>>>> On 03/09/2015 09:48 AM, Michal Simek wrote: >>>>>>> Remove Kconfig dependency and enable driver for >>>>>>> all ARCHs. >>>>>>> >>>>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>>>>> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> >>>>>>> --- >>>>>>> >>>>>>> Test for all archs done by Kbuild test robot without any problem. >>>>>>> --- >>>>>>> drivers/net/can/Kconfig | 1 - >>>>>>> 1 file changed, 1 deletion(-) >>>>>>> >>>>>>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig >>>>>>> index 98d73aab52fe..f690c3fb3088 100644 >>>>>>> --- a/drivers/net/can/Kconfig >>>>>>> +++ b/drivers/net/can/Kconfig >>>>>>> @@ -131,7 +131,6 @@ config CAN_RCAR >>>>>>> >>>>>>> config CAN_XILINXCAN >>>>>>> tristate "Xilinx CAN" >>>>>>> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST >>>>>> >>>>>> I think that's what COMPILE_TEST ist for? >>>>> >>>>> For compilation yes but not for enabling. Currently this driver >>>>> can be also used on ARM64 that's why people suggesting directly >>>>> to remove dependency on arch and then COMPILE_TEST can be removed >>>>> too. >>>> >>>> In the past (May 2014) I had people complaining that certain ARM SoC >>>> specific drivers are enabled on ARM in general, not just on that SoC. As >>>> I'm not following arm64 in detail, has the notion of using depends on >>>> ARCH changes since then? >>>> >>>>> Or do you want me to change description to mention that this is for >>>>> ARM64 enabling? >>>> >>>> Given this is consensus, a remark to ARM64 would be appreciated. :) >>> >>> David has applied this patch which is in general just the same as this one. >>> >>> (linux-next) Remove architecture dependency >>> 28811a8c00fe0d899b8a544421f3b4947425d5e8 >>> >>> Mark Brown has suggested to do so for spi and don't check architecture at >>> all. >>> I have also sent similar patch for watchdog driver too. >>> >>> I think it is up to you if you want to add ARM64 to Kconfig or just remove >>> that arch dependencies. >>> To be honest my goal is to enable this driver for ARM64. >>> Please tell me what way you prefer. >> >> I like the idea of removing the depends on ARCH completely. Jean, what >> do you think? > > Removing the dependency completely will let the option be displayed on > systems where the driver is useless. I am in favor of having hardware > dependencies on as many drivers as possible to avoid bothering the user > with irrelevant questions. The list of Kconfig entries has grown a lot > over time! > > If the current dependency is too strict then I would suggest to extend > it or to make it broader (depends on ARM || ARM64 || COMPILE_TEST would > be acceptable IMHO.) Dropping it completely only makes sense if the part > is used on so many systems that the dependency becomes too long or is a > pain to maintain. Sounds reasonable. Michael, make it so. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] net: can: Enable xilinx driver for all ARCHs 2015-03-09 13:55 ` Marc Kleine-Budde @ 2015-03-09 14:04 ` Michal Simek 2015-03-09 15:51 ` Sören Brinkmann 0 siblings, 1 reply; 11+ messages in thread From: Michal Simek @ 2015-03-09 14:04 UTC (permalink / raw) To: Marc Kleine-Budde, Jean Delvare Cc: Michal Simek, linux-kernel, monstr, Wolfgang Grandegger, linux-can, netdev [-- Attachment #1: Type: text/plain, Size: 3518 bytes --] On 03/09/2015 02:55 PM, Marc Kleine-Budde wrote: > On 03/09/2015 02:53 PM, Jean Delvare wrote: >> Le Monday 09 March 2015 à 10:56 +0100, Marc Kleine-Budde a écrit : >>> On 03/09/2015 10:52 AM, Michal Simek wrote: >>>> On 03/09/2015 10:13 AM, Marc Kleine-Budde wrote: >>>>> On 03/09/2015 09:58 AM, Michal Simek wrote: >>>>>> On 03/09/2015 09:50 AM, Marc Kleine-Budde wrote: >>>>>>> On 03/09/2015 09:48 AM, Michal Simek wrote: >>>>>>>> Remove Kconfig dependency and enable driver for >>>>>>>> all ARCHs. >>>>>>>> >>>>>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >>>>>>>> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> >>>>>>>> --- >>>>>>>> >>>>>>>> Test for all archs done by Kbuild test robot without any problem. >>>>>>>> --- >>>>>>>> drivers/net/can/Kconfig | 1 - >>>>>>>> 1 file changed, 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig >>>>>>>> index 98d73aab52fe..f690c3fb3088 100644 >>>>>>>> --- a/drivers/net/can/Kconfig >>>>>>>> +++ b/drivers/net/can/Kconfig >>>>>>>> @@ -131,7 +131,6 @@ config CAN_RCAR >>>>>>>> >>>>>>>> config CAN_XILINXCAN >>>>>>>> tristate "Xilinx CAN" >>>>>>>> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST >>>>>>> >>>>>>> I think that's what COMPILE_TEST ist for? >>>>>> >>>>>> For compilation yes but not for enabling. Currently this driver >>>>>> can be also used on ARM64 that's why people suggesting directly >>>>>> to remove dependency on arch and then COMPILE_TEST can be removed >>>>>> too. >>>>> >>>>> In the past (May 2014) I had people complaining that certain ARM SoC >>>>> specific drivers are enabled on ARM in general, not just on that SoC. As >>>>> I'm not following arm64 in detail, has the notion of using depends on >>>>> ARCH changes since then? >>>>> >>>>>> Or do you want me to change description to mention that this is for >>>>>> ARM64 enabling? >>>>> >>>>> Given this is consensus, a remark to ARM64 would be appreciated. :) >>>> >>>> David has applied this patch which is in general just the same as this one. >>>> >>>> (linux-next) Remove architecture dependency >>>> 28811a8c00fe0d899b8a544421f3b4947425d5e8 >>>> >>>> Mark Brown has suggested to do so for spi and don't check architecture at >>>> all. >>>> I have also sent similar patch for watchdog driver too. >>>> >>>> I think it is up to you if you want to add ARM64 to Kconfig or just remove >>>> that arch dependencies. >>>> To be honest my goal is to enable this driver for ARM64. >>>> Please tell me what way you prefer. >>> >>> I like the idea of removing the depends on ARCH completely. Jean, what >>> do you think? >> >> Removing the dependency completely will let the option be displayed on >> systems where the driver is useless. I am in favor of having hardware >> dependencies on as many drivers as possible to avoid bothering the user >> with irrelevant questions. The list of Kconfig entries has grown a lot >> over time! >> >> If the current dependency is too strict then I would suggest to extend >> it or to make it broader (depends on ARM || ARM64 || COMPILE_TEST would >> be acceptable IMHO.) Dropping it completely only makes sense if the part >> is used on so many systems that the dependency becomes too long or is a >> pain to maintain. > > Sounds reasonable. Michael, make it so. I have sent v2 which add arm64 to Kconfig and I am keeping just dependency on ARCH_ZYNQ not all ARM platforms. Thanks, Michal [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] net: can: Enable xilinx driver for all ARCHs 2015-03-09 14:04 ` Michal Simek @ 2015-03-09 15:51 ` Sören Brinkmann 2015-03-09 15:56 ` Marc Kleine-Budde 0 siblings, 1 reply; 11+ messages in thread From: Sören Brinkmann @ 2015-03-09 15:51 UTC (permalink / raw) To: Michal Simek Cc: Marc Kleine-Budde, Jean Delvare, linux-kernel, monstr, Wolfgang Grandegger, linux-can, netdev On Mon, 2015-03-09 at 03:04PM +0100, Michal Simek wrote: > On 03/09/2015 02:55 PM, Marc Kleine-Budde wrote: > > On 03/09/2015 02:53 PM, Jean Delvare wrote: > >> Le Monday 09 March 2015 à 10:56 +0100, Marc Kleine-Budde a écrit : > >>> On 03/09/2015 10:52 AM, Michal Simek wrote: > >>>> On 03/09/2015 10:13 AM, Marc Kleine-Budde wrote: > >>>>> On 03/09/2015 09:58 AM, Michal Simek wrote: > >>>>>> On 03/09/2015 09:50 AM, Marc Kleine-Budde wrote: > >>>>>>> On 03/09/2015 09:48 AM, Michal Simek wrote: > >>>>>>>> Remove Kconfig dependency and enable driver for > >>>>>>>> all ARCHs. > >>>>>>>> > >>>>>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > >>>>>>>> Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com> > >>>>>>>> --- > >>>>>>>> > >>>>>>>> Test for all archs done by Kbuild test robot without any problem. > >>>>>>>> --- > >>>>>>>> drivers/net/can/Kconfig | 1 - > >>>>>>>> 1 file changed, 1 deletion(-) > >>>>>>>> > >>>>>>>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig > >>>>>>>> index 98d73aab52fe..f690c3fb3088 100644 > >>>>>>>> --- a/drivers/net/can/Kconfig > >>>>>>>> +++ b/drivers/net/can/Kconfig > >>>>>>>> @@ -131,7 +131,6 @@ config CAN_RCAR > >>>>>>>> > >>>>>>>> config CAN_XILINXCAN > >>>>>>>> tristate "Xilinx CAN" > >>>>>>>> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST > >>>>>>> > >>>>>>> I think that's what COMPILE_TEST ist for? > >>>>>> > >>>>>> For compilation yes but not for enabling. Currently this driver > >>>>>> can be also used on ARM64 that's why people suggesting directly > >>>>>> to remove dependency on arch and then COMPILE_TEST can be removed > >>>>>> too. > >>>>> > >>>>> In the past (May 2014) I had people complaining that certain ARM SoC > >>>>> specific drivers are enabled on ARM in general, not just on that SoC. As > >>>>> I'm not following arm64 in detail, has the notion of using depends on > >>>>> ARCH changes since then? > >>>>> > >>>>>> Or do you want me to change description to mention that this is for > >>>>>> ARM64 enabling? > >>>>> > >>>>> Given this is consensus, a remark to ARM64 would be appreciated. :) > >>>> > >>>> David has applied this patch which is in general just the same as this one. > >>>> > >>>> (linux-next) Remove architecture dependency > >>>> 28811a8c00fe0d899b8a544421f3b4947425d5e8 > >>>> > >>>> Mark Brown has suggested to do so for spi and don't check architecture at > >>>> all. > >>>> I have also sent similar patch for watchdog driver too. > >>>> > >>>> I think it is up to you if you want to add ARM64 to Kconfig or just remove > >>>> that arch dependencies. > >>>> To be honest my goal is to enable this driver for ARM64. > >>>> Please tell me what way you prefer. > >>> > >>> I like the idea of removing the depends on ARCH completely. Jean, what > >>> do you think? > >> > >> Removing the dependency completely will let the option be displayed on > >> systems where the driver is useless. I am in favor of having hardware > >> dependencies on as many drivers as possible to avoid bothering the user > >> with irrelevant questions. The list of Kconfig entries has grown a lot > >> over time! > >> > >> If the current dependency is too strict then I would suggest to extend > >> it or to make it broader (depends on ARM || ARM64 || COMPILE_TEST would > >> be acceptable IMHO.) Dropping it completely only makes sense if the part > >> is used on so many systems that the dependency becomes too long or is a > >> pain to maintain. > > > > Sounds reasonable. Michael, make it so. > > I have sent v2 which add arm64 to Kconfig and I am keeping just dependency on > ARCH_ZYNQ not all ARM platforms. You could (and some people do that with some devices) use these devices from x86(_64) if you plug your FPGA/Zynq platform into a PCIe slot (FWIW, this should work for any platform that supports PCIe). I think we just had somebody sending patches to enable the Zynq UART, IIRC, for x86. Sören ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] net: can: Enable xilinx driver for all ARCHs 2015-03-09 15:51 ` Sören Brinkmann @ 2015-03-09 15:56 ` Marc Kleine-Budde 0 siblings, 0 replies; 11+ messages in thread From: Marc Kleine-Budde @ 2015-03-09 15:56 UTC (permalink / raw) To: Sören Brinkmann, Michal Simek Cc: Jean Delvare, linux-kernel, monstr, Wolfgang Grandegger, linux-can, netdev [-- Attachment #1: Type: text/plain, Size: 905 bytes --] On 03/09/2015 04:51 PM, Sören Brinkmann wrote: >>> Sounds reasonable. Michael, make it so. >> >> I have sent v2 which add arm64 to Kconfig and I am keeping just dependency on >> ARCH_ZYNQ not all ARM platforms. > > You could (and some people do that with some devices) use these devices > from x86(_64) if you plug your FPGA/Zynq platform into a PCIe slot > (FWIW, this should work for any platform that supports PCIe). I think we > just had somebody sending patches to enable the Zynq UART, IIRC, for x86. Nice :) The "depends on" can easily be changed with once there's PCIe glue code for the driver. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-03-09 15:56 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-09 8:48 [PATCH] net: can: Enable xilinx driver for all ARCHs Michal Simek 2015-03-09 8:50 ` Marc Kleine-Budde 2015-03-09 8:58 ` Michal Simek 2015-03-09 9:13 ` Marc Kleine-Budde 2015-03-09 9:52 ` Michal Simek 2015-03-09 9:56 ` Marc Kleine-Budde 2015-03-09 13:53 ` Jean Delvare 2015-03-09 13:55 ` Marc Kleine-Budde 2015-03-09 14:04 ` Michal Simek 2015-03-09 15:51 ` Sören Brinkmann 2015-03-09 15:56 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).