From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: Cong Wang <cwang@twopensource.com>
Subject: Re: [Patch net-next] net_sched: destroy proto tp when all filters are gone
Date: Mon, 09 Mar 2015 09:43:26 -0400 [thread overview]
Message-ID: <54FDA37E.5090603@mojatatu.com> (raw)
In-Reply-To: <1425671279-25399-1-git-send-email-xiyou.wangcong@gmail.com>
On 03/06/15 14:47, Cong Wang wrote:
> From: Cong Wang<cwang@twopensource.com>
>
> Kernel automatically creates a tp for each
> (kind, protocol, priority) tuple, which has handle 0,
> when we add a new filter, but it still is left there
> after we remove our own, unless we don't specify the
> handle (literally means all the filters under
> the tuple). For example this one is left:
>
> # tc filter show dev eth0
> filter parent 8001: protocol arp pref 49152 basic
>
> The user-space is hard to clean up these for kernel
> because filters like u32 are organized in a complex way.
> So kernel is responsible to remove it after all filters
> are gone. Each type of filter has its own way to
> store the filters, so each type has to provide its
> way to check if all filters are gone.
>
> Cc: Jamal Hadi Salim<jhs@mojatatu.com>
> Signed-off-by: Cong Wang<cwang@twopensource.com>
> Signed-off-by: Cong Wang<xiyou.wangcong@gmail.com>
Acked-by: Jamal Hadi Salim<jhs@mojatatu.com>
cheers,
jamal
next prev parent reply other threads:[~2015-03-09 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 19:47 [Patch net-next] net_sched: destroy proto tp when all filters are gone Cong Wang
2015-03-09 2:29 ` David Miller
2015-03-09 13:43 ` Jamal Hadi Salim [this message]
2015-03-09 19:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FDA37E.5090603@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=cwang@twopensource.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).