* [patch net-next] switchdev: use gpl variant of symbol export
@ 2015-03-09 9:26 Jiri Pirko
2015-03-09 15:52 ` Scott Feldman
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Jiri Pirko @ 2015-03-09 9:26 UTC (permalink / raw)
To: netdev; +Cc: davem, f.fainelli, sfeldma
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
net/switchdev/switchdev.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
index 19e4e72..aba6aa2 100644
--- a/net/switchdev/switchdev.c
+++ b/net/switchdev/switchdev.c
@@ -33,7 +33,7 @@ int netdev_switch_parent_id_get(struct net_device *dev,
return -EOPNOTSUPP;
return ops->ndo_switch_parent_id_get(dev, psid);
}
-EXPORT_SYMBOL(netdev_switch_parent_id_get);
+EXPORT_SYMBOL_GPL(netdev_switch_parent_id_get);
/**
* netdev_switch_port_stp_update - Notify switch device port of STP
@@ -52,7 +52,7 @@ int netdev_switch_port_stp_update(struct net_device *dev, u8 state)
WARN_ON(!ops->ndo_switch_parent_id_get);
return ops->ndo_switch_port_stp_update(dev, state);
}
-EXPORT_SYMBOL(netdev_switch_port_stp_update);
+EXPORT_SYMBOL_GPL(netdev_switch_port_stp_update);
static DEFINE_MUTEX(netdev_switch_mutex);
static RAW_NOTIFIER_HEAD(netdev_switch_notif_chain);
@@ -74,7 +74,7 @@ int register_netdev_switch_notifier(struct notifier_block *nb)
mutex_unlock(&netdev_switch_mutex);
return err;
}
-EXPORT_SYMBOL(register_netdev_switch_notifier);
+EXPORT_SYMBOL_GPL(register_netdev_switch_notifier);
/**
* unregister_netdev_switch_notifier - Unregister nofifier
@@ -92,7 +92,7 @@ int unregister_netdev_switch_notifier(struct notifier_block *nb)
mutex_unlock(&netdev_switch_mutex);
return err;
}
-EXPORT_SYMBOL(unregister_netdev_switch_notifier);
+EXPORT_SYMBOL_GPL(unregister_netdev_switch_notifier);
/**
* call_netdev_switch_notifiers - Call nofifiers
@@ -115,7 +115,7 @@ int call_netdev_switch_notifiers(unsigned long val, struct net_device *dev,
mutex_unlock(&netdev_switch_mutex);
return err;
}
-EXPORT_SYMBOL(call_netdev_switch_notifiers);
+EXPORT_SYMBOL_GPL(call_netdev_switch_notifiers);
/**
* netdev_switch_port_bridge_setlink - Notify switch device port of bridge
@@ -140,7 +140,7 @@ int netdev_switch_port_bridge_setlink(struct net_device *dev,
return ops->ndo_bridge_setlink(dev, nlh, flags);
}
-EXPORT_SYMBOL(netdev_switch_port_bridge_setlink);
+EXPORT_SYMBOL_GPL(netdev_switch_port_bridge_setlink);
/**
* netdev_switch_port_bridge_dellink - Notify switch device port of bridge
@@ -165,7 +165,7 @@ int netdev_switch_port_bridge_dellink(struct net_device *dev,
return ops->ndo_bridge_dellink(dev, nlh, flags);
}
-EXPORT_SYMBOL(netdev_switch_port_bridge_dellink);
+EXPORT_SYMBOL_GPL(netdev_switch_port_bridge_dellink);
/**
* ndo_dflt_netdev_switch_port_bridge_setlink - default ndo bridge setlink
@@ -195,7 +195,7 @@ int ndo_dflt_netdev_switch_port_bridge_setlink(struct net_device *dev,
return ret;
}
-EXPORT_SYMBOL(ndo_dflt_netdev_switch_port_bridge_setlink);
+EXPORT_SYMBOL_GPL(ndo_dflt_netdev_switch_port_bridge_setlink);
/**
* ndo_dflt_netdev_switch_port_bridge_dellink - default ndo bridge dellink
@@ -225,7 +225,7 @@ int ndo_dflt_netdev_switch_port_bridge_dellink(struct net_device *dev,
return ret;
}
-EXPORT_SYMBOL(ndo_dflt_netdev_switch_port_bridge_dellink);
+EXPORT_SYMBOL_GPL(ndo_dflt_netdev_switch_port_bridge_dellink);
static struct net_device *netdev_switch_get_lowest_dev(struct net_device *dev)
{
@@ -331,7 +331,7 @@ int netdev_switch_fib_ipv4_add(u32 dst, int dst_len, struct fib_info *fi,
return err;
}
-EXPORT_SYMBOL(netdev_switch_fib_ipv4_add);
+EXPORT_SYMBOL_GPL(netdev_switch_fib_ipv4_add);
/**
* netdev_switch_fib_ipv4_del - Delete IPv4 route entry from switch
@@ -369,7 +369,7 @@ int netdev_switch_fib_ipv4_del(u32 dst, int dst_len, struct fib_info *fi,
return err;
}
-EXPORT_SYMBOL(netdev_switch_fib_ipv4_del);
+EXPORT_SYMBOL_GPL(netdev_switch_fib_ipv4_del);
/**
* netdev_switch_fib_ipv4_abort - Abort an IPv4 FIB operation
@@ -389,4 +389,4 @@ void netdev_switch_fib_ipv4_abort(struct fib_info *fi)
fib_flush_external(fi->fib_net);
fi->fib_net->ipv4.fib_offload_disabled = true;
}
-EXPORT_SYMBOL(netdev_switch_fib_ipv4_abort);
+EXPORT_SYMBOL_GPL(netdev_switch_fib_ipv4_abort);
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [patch net-next] switchdev: use gpl variant of symbol export
2015-03-09 9:26 [patch net-next] switchdev: use gpl variant of symbol export Jiri Pirko
@ 2015-03-09 15:52 ` Scott Feldman
2015-03-09 16:02 ` Andy Gospodarek
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Scott Feldman @ 2015-03-09 15:52 UTC (permalink / raw)
To: Jiri Pirko; +Cc: Netdev, David S. Miller, Florian Fainelli
On Mon, Mar 9, 2015 at 2:26 AM, Jiri Pirko <jiri@resnulli.us> wrote:
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Acked-by: Scott Feldman <sfeldma@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch net-next] switchdev: use gpl variant of symbol export
2015-03-09 9:26 [patch net-next] switchdev: use gpl variant of symbol export Jiri Pirko
2015-03-09 15:52 ` Scott Feldman
@ 2015-03-09 16:02 ` Andy Gospodarek
2015-03-09 17:11 ` Florian Fainelli
2015-03-09 19:39 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: Andy Gospodarek @ 2015-03-09 16:02 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, davem, f.fainelli, sfeldma
On Mon, Mar 09, 2015 at 10:26:24AM +0100, Jiri Pirko wrote:
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Good catch!
Acked-by: Andy Gospodarek <gospo@cumulusnetworks.com>
> ---
> net/switchdev/switchdev.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
> index 19e4e72..aba6aa2 100644
> --- a/net/switchdev/switchdev.c
> +++ b/net/switchdev/switchdev.c
> @@ -33,7 +33,7 @@ int netdev_switch_parent_id_get(struct net_device *dev,
> return -EOPNOTSUPP;
> return ops->ndo_switch_parent_id_get(dev, psid);
> }
> -EXPORT_SYMBOL(netdev_switch_parent_id_get);
> +EXPORT_SYMBOL_GPL(netdev_switch_parent_id_get);
>
> /**
> * netdev_switch_port_stp_update - Notify switch device port of STP
> @@ -52,7 +52,7 @@ int netdev_switch_port_stp_update(struct net_device *dev, u8 state)
> WARN_ON(!ops->ndo_switch_parent_id_get);
> return ops->ndo_switch_port_stp_update(dev, state);
> }
> -EXPORT_SYMBOL(netdev_switch_port_stp_update);
> +EXPORT_SYMBOL_GPL(netdev_switch_port_stp_update);
>
> static DEFINE_MUTEX(netdev_switch_mutex);
> static RAW_NOTIFIER_HEAD(netdev_switch_notif_chain);
> @@ -74,7 +74,7 @@ int register_netdev_switch_notifier(struct notifier_block *nb)
> mutex_unlock(&netdev_switch_mutex);
> return err;
> }
> -EXPORT_SYMBOL(register_netdev_switch_notifier);
> +EXPORT_SYMBOL_GPL(register_netdev_switch_notifier);
>
> /**
> * unregister_netdev_switch_notifier - Unregister nofifier
> @@ -92,7 +92,7 @@ int unregister_netdev_switch_notifier(struct notifier_block *nb)
> mutex_unlock(&netdev_switch_mutex);
> return err;
> }
> -EXPORT_SYMBOL(unregister_netdev_switch_notifier);
> +EXPORT_SYMBOL_GPL(unregister_netdev_switch_notifier);
>
> /**
> * call_netdev_switch_notifiers - Call nofifiers
> @@ -115,7 +115,7 @@ int call_netdev_switch_notifiers(unsigned long val, struct net_device *dev,
> mutex_unlock(&netdev_switch_mutex);
> return err;
> }
> -EXPORT_SYMBOL(call_netdev_switch_notifiers);
> +EXPORT_SYMBOL_GPL(call_netdev_switch_notifiers);
>
> /**
> * netdev_switch_port_bridge_setlink - Notify switch device port of bridge
> @@ -140,7 +140,7 @@ int netdev_switch_port_bridge_setlink(struct net_device *dev,
>
> return ops->ndo_bridge_setlink(dev, nlh, flags);
> }
> -EXPORT_SYMBOL(netdev_switch_port_bridge_setlink);
> +EXPORT_SYMBOL_GPL(netdev_switch_port_bridge_setlink);
>
> /**
> * netdev_switch_port_bridge_dellink - Notify switch device port of bridge
> @@ -165,7 +165,7 @@ int netdev_switch_port_bridge_dellink(struct net_device *dev,
>
> return ops->ndo_bridge_dellink(dev, nlh, flags);
> }
> -EXPORT_SYMBOL(netdev_switch_port_bridge_dellink);
> +EXPORT_SYMBOL_GPL(netdev_switch_port_bridge_dellink);
>
> /**
> * ndo_dflt_netdev_switch_port_bridge_setlink - default ndo bridge setlink
> @@ -195,7 +195,7 @@ int ndo_dflt_netdev_switch_port_bridge_setlink(struct net_device *dev,
>
> return ret;
> }
> -EXPORT_SYMBOL(ndo_dflt_netdev_switch_port_bridge_setlink);
> +EXPORT_SYMBOL_GPL(ndo_dflt_netdev_switch_port_bridge_setlink);
>
> /**
> * ndo_dflt_netdev_switch_port_bridge_dellink - default ndo bridge dellink
> @@ -225,7 +225,7 @@ int ndo_dflt_netdev_switch_port_bridge_dellink(struct net_device *dev,
>
> return ret;
> }
> -EXPORT_SYMBOL(ndo_dflt_netdev_switch_port_bridge_dellink);
> +EXPORT_SYMBOL_GPL(ndo_dflt_netdev_switch_port_bridge_dellink);
>
> static struct net_device *netdev_switch_get_lowest_dev(struct net_device *dev)
> {
> @@ -331,7 +331,7 @@ int netdev_switch_fib_ipv4_add(u32 dst, int dst_len, struct fib_info *fi,
>
> return err;
> }
> -EXPORT_SYMBOL(netdev_switch_fib_ipv4_add);
> +EXPORT_SYMBOL_GPL(netdev_switch_fib_ipv4_add);
>
> /**
> * netdev_switch_fib_ipv4_del - Delete IPv4 route entry from switch
> @@ -369,7 +369,7 @@ int netdev_switch_fib_ipv4_del(u32 dst, int dst_len, struct fib_info *fi,
>
> return err;
> }
> -EXPORT_SYMBOL(netdev_switch_fib_ipv4_del);
> +EXPORT_SYMBOL_GPL(netdev_switch_fib_ipv4_del);
>
> /**
> * netdev_switch_fib_ipv4_abort - Abort an IPv4 FIB operation
> @@ -389,4 +389,4 @@ void netdev_switch_fib_ipv4_abort(struct fib_info *fi)
> fib_flush_external(fi->fib_net);
> fi->fib_net->ipv4.fib_offload_disabled = true;
> }
> -EXPORT_SYMBOL(netdev_switch_fib_ipv4_abort);
> +EXPORT_SYMBOL_GPL(netdev_switch_fib_ipv4_abort);
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch net-next] switchdev: use gpl variant of symbol export
2015-03-09 9:26 [patch net-next] switchdev: use gpl variant of symbol export Jiri Pirko
2015-03-09 15:52 ` Scott Feldman
2015-03-09 16:02 ` Andy Gospodarek
@ 2015-03-09 17:11 ` Florian Fainelli
2015-03-09 19:39 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2015-03-09 17:11 UTC (permalink / raw)
To: Jiri Pirko, netdev; +Cc: davem, sfeldma
On 09/03/15 02:26, Jiri Pirko wrote:
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Note: this still won't prevent vendors from doing trampoline drivers,
but at least they will have to make their shim be appropriately marked
as GPL or compatible when doing this as a module.
> ---
> net/switchdev/switchdev.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
> index 19e4e72..aba6aa2 100644
> --- a/net/switchdev/switchdev.c
> +++ b/net/switchdev/switchdev.c
> @@ -33,7 +33,7 @@ int netdev_switch_parent_id_get(struct net_device *dev,
> return -EOPNOTSUPP;
> return ops->ndo_switch_parent_id_get(dev, psid);
> }
> -EXPORT_SYMBOL(netdev_switch_parent_id_get);
> +EXPORT_SYMBOL_GPL(netdev_switch_parent_id_get);
>
> /**
> * netdev_switch_port_stp_update - Notify switch device port of STP
> @@ -52,7 +52,7 @@ int netdev_switch_port_stp_update(struct net_device *dev, u8 state)
> WARN_ON(!ops->ndo_switch_parent_id_get);
> return ops->ndo_switch_port_stp_update(dev, state);
> }
> -EXPORT_SYMBOL(netdev_switch_port_stp_update);
> +EXPORT_SYMBOL_GPL(netdev_switch_port_stp_update);
>
> static DEFINE_MUTEX(netdev_switch_mutex);
> static RAW_NOTIFIER_HEAD(netdev_switch_notif_chain);
> @@ -74,7 +74,7 @@ int register_netdev_switch_notifier(struct notifier_block *nb)
> mutex_unlock(&netdev_switch_mutex);
> return err;
> }
> -EXPORT_SYMBOL(register_netdev_switch_notifier);
> +EXPORT_SYMBOL_GPL(register_netdev_switch_notifier);
>
> /**
> * unregister_netdev_switch_notifier - Unregister nofifier
> @@ -92,7 +92,7 @@ int unregister_netdev_switch_notifier(struct notifier_block *nb)
> mutex_unlock(&netdev_switch_mutex);
> return err;
> }
> -EXPORT_SYMBOL(unregister_netdev_switch_notifier);
> +EXPORT_SYMBOL_GPL(unregister_netdev_switch_notifier);
>
> /**
> * call_netdev_switch_notifiers - Call nofifiers
> @@ -115,7 +115,7 @@ int call_netdev_switch_notifiers(unsigned long val, struct net_device *dev,
> mutex_unlock(&netdev_switch_mutex);
> return err;
> }
> -EXPORT_SYMBOL(call_netdev_switch_notifiers);
> +EXPORT_SYMBOL_GPL(call_netdev_switch_notifiers);
>
> /**
> * netdev_switch_port_bridge_setlink - Notify switch device port of bridge
> @@ -140,7 +140,7 @@ int netdev_switch_port_bridge_setlink(struct net_device *dev,
>
> return ops->ndo_bridge_setlink(dev, nlh, flags);
> }
> -EXPORT_SYMBOL(netdev_switch_port_bridge_setlink);
> +EXPORT_SYMBOL_GPL(netdev_switch_port_bridge_setlink);
>
> /**
> * netdev_switch_port_bridge_dellink - Notify switch device port of bridge
> @@ -165,7 +165,7 @@ int netdev_switch_port_bridge_dellink(struct net_device *dev,
>
> return ops->ndo_bridge_dellink(dev, nlh, flags);
> }
> -EXPORT_SYMBOL(netdev_switch_port_bridge_dellink);
> +EXPORT_SYMBOL_GPL(netdev_switch_port_bridge_dellink);
>
> /**
> * ndo_dflt_netdev_switch_port_bridge_setlink - default ndo bridge setlink
> @@ -195,7 +195,7 @@ int ndo_dflt_netdev_switch_port_bridge_setlink(struct net_device *dev,
>
> return ret;
> }
> -EXPORT_SYMBOL(ndo_dflt_netdev_switch_port_bridge_setlink);
> +EXPORT_SYMBOL_GPL(ndo_dflt_netdev_switch_port_bridge_setlink);
>
> /**
> * ndo_dflt_netdev_switch_port_bridge_dellink - default ndo bridge dellink
> @@ -225,7 +225,7 @@ int ndo_dflt_netdev_switch_port_bridge_dellink(struct net_device *dev,
>
> return ret;
> }
> -EXPORT_SYMBOL(ndo_dflt_netdev_switch_port_bridge_dellink);
> +EXPORT_SYMBOL_GPL(ndo_dflt_netdev_switch_port_bridge_dellink);
>
> static struct net_device *netdev_switch_get_lowest_dev(struct net_device *dev)
> {
> @@ -331,7 +331,7 @@ int netdev_switch_fib_ipv4_add(u32 dst, int dst_len, struct fib_info *fi,
>
> return err;
> }
> -EXPORT_SYMBOL(netdev_switch_fib_ipv4_add);
> +EXPORT_SYMBOL_GPL(netdev_switch_fib_ipv4_add);
>
> /**
> * netdev_switch_fib_ipv4_del - Delete IPv4 route entry from switch
> @@ -369,7 +369,7 @@ int netdev_switch_fib_ipv4_del(u32 dst, int dst_len, struct fib_info *fi,
>
> return err;
> }
> -EXPORT_SYMBOL(netdev_switch_fib_ipv4_del);
> +EXPORT_SYMBOL_GPL(netdev_switch_fib_ipv4_del);
>
> /**
> * netdev_switch_fib_ipv4_abort - Abort an IPv4 FIB operation
> @@ -389,4 +389,4 @@ void netdev_switch_fib_ipv4_abort(struct fib_info *fi)
> fib_flush_external(fi->fib_net);
> fi->fib_net->ipv4.fib_offload_disabled = true;
> }
> -EXPORT_SYMBOL(netdev_switch_fib_ipv4_abort);
> +EXPORT_SYMBOL_GPL(netdev_switch_fib_ipv4_abort);
>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch net-next] switchdev: use gpl variant of symbol export
2015-03-09 9:26 [patch net-next] switchdev: use gpl variant of symbol export Jiri Pirko
` (2 preceding siblings ...)
2015-03-09 17:11 ` Florian Fainelli
@ 2015-03-09 19:39 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2015-03-09 19:39 UTC (permalink / raw)
To: jiri; +Cc: netdev, f.fainelli, sfeldma
From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 9 Mar 2015 10:26:24 +0100
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-03-09 19:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-09 9:26 [patch net-next] switchdev: use gpl variant of symbol export Jiri Pirko
2015-03-09 15:52 ` Scott Feldman
2015-03-09 16:02 ` Andy Gospodarek
2015-03-09 17:11 ` Florian Fainelli
2015-03-09 19:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).