From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, mkl@pengutronix.de,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Alexander Duyck <alexander.h.duyck@redhat.com>
Subject: Re: [PATCH] can: use sock_efree instead of own destructor
Date: Tue, 10 Mar 2015 15:55:32 +0100 [thread overview]
Message-ID: <54FF05E4.6060002@hartkopp.net> (raw)
In-Reply-To: <1425998185.8261.51.camel@edumazet-glaptop2.roam.corp.google.com>
On 03/10/2015 03:36 PM, Eric Dumazet wrote:
> On Tue, 2015-03-10 at 14:36 +0100, Oliver Hartkopp wrote:
>> Maybe Alexander can send a patch which adds a comment, as I don't know if I
>> would find the best words for it.
>
> Please do not top post on netdev.
? I did not.
> If you cannot find best words for it, maybe a comment would not be
> useful : Very often, best comments are added by people that had problems
> to understand the code ;)
Yes that's why I asked the original author to do so - he hopefully understood
his code :-)
>
> I do not trust comments, I prefer using "git grep" or tools like that to
> check call sites.
>
> In this particular case this becomes clear, while being concise.
>
> # git grep -n sock_efree
A good hint! Will use this first in the future.
Thanks,
Oliver
next prev parent reply other threads:[~2015-03-10 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1425959300-27132-1-git-send-email-fw@strlen.de>
2015-03-10 6:14 ` [PATCH] can: use sock_efree instead of own destructor Oliver Hartkopp
2015-03-10 12:22 ` Eric Dumazet
2015-03-10 13:36 ` Oliver Hartkopp
2015-03-10 14:36 ` Eric Dumazet
2015-03-10 14:55 ` Oliver Hartkopp [this message]
2015-03-10 15:19 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FF05E4.6060002@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=alexander.h.duyck@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).