netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: add comment for sock_efree() usage
@ 2015-03-10 18:03 Oliver Hartkopp
  2015-03-10 18:32 ` Alexander Duyck
  2015-03-10 20:12 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Oliver Hartkopp @ 2015-03-10 18:03 UTC (permalink / raw)
  To: netdev; +Cc: eric.dumazet, alexander.h.duyck, Oliver Hartkopp

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
---
 net/core/sock.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/core/sock.c b/net/core/sock.c
index 93c8b20..78e89eb 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1655,6 +1655,10 @@ void sock_rfree(struct sk_buff *skb)
 }
 EXPORT_SYMBOL(sock_rfree);
 
+/*
+ * Buffer destructor for skbs that are not used directly in read or write
+ * path, e.g. for error handler skbs. Automatically called from kfree_skb.
+ */
 void sock_efree(struct sk_buff *skb)
 {
 	sock_put(skb->sk);
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: add comment for sock_efree() usage
  2015-03-10 18:03 [PATCH] net: add comment for sock_efree() usage Oliver Hartkopp
@ 2015-03-10 18:32 ` Alexander Duyck
  2015-03-10 20:12 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Alexander Duyck @ 2015-03-10 18:32 UTC (permalink / raw)
  To: Oliver Hartkopp, netdev; +Cc: eric.dumazet


On 03/10/2015 11:03 AM, Oliver Hartkopp wrote:
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> ---
>   net/core/sock.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/net/core/sock.c b/net/core/sock.c
> index 93c8b20..78e89eb 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -1655,6 +1655,10 @@ void sock_rfree(struct sk_buff *skb)
>   }
>   EXPORT_SYMBOL(sock_rfree);
>   
> +/*
> + * Buffer destructor for skbs that are not used directly in read or write
> + * path, e.g. for error handler skbs. Automatically called from kfree_skb.
> + */
>   void sock_efree(struct sk_buff *skb)
>   {
>   	sock_put(skb->sk);

Acked-by: Alexander Duyck <alexander.h.duyck@redhat.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: add comment for sock_efree() usage
  2015-03-10 18:03 [PATCH] net: add comment for sock_efree() usage Oliver Hartkopp
  2015-03-10 18:32 ` Alexander Duyck
@ 2015-03-10 20:12 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-03-10 20:12 UTC (permalink / raw)
  To: socketcan; +Cc: netdev, eric.dumazet, alexander.h.duyck

From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Tue, 10 Mar 2015 19:03:46 +0100

> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-10 20:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-10 18:03 [PATCH] net: add comment for sock_efree() usage Oliver Hartkopp
2015-03-10 18:32 ` Alexander Duyck
2015-03-10 20:12 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).