From: Alexander Duyck <alexander.h.duyck@redhat.com>
To: Sabrina Dubroca <sd@queasysnail.net>, davem@davemloft.net
Cc: netdev@vger.kernel.org, sfeldma@gmail.com
Subject: Re: [PATCH net-next] fib_trie: call fib_table_flush_external under RTNL
Date: Tue, 10 Mar 2015 13:38:03 -0700 [thread overview]
Message-ID: <54FF562B.2060701@redhat.com> (raw)
In-Reply-To: <1426017834-24209-1-git-send-email-sd@queasysnail.net>
On 03/10/2015 01:03 PM, Sabrina Dubroca wrote:
> Move rtnl_lock() before the call to fib4_rules_exit so that
> fib_table_flush_external is called under RTNL.
>
> Fixes: 104616e74e0b ("switchdev: don't support custom ip rules, for now")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> ---
> net/ipv4/fib_frontend.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
> index e067770235bf..ed94bc80eb78 100644
> --- a/net/ipv4/fib_frontend.c
> +++ b/net/ipv4/fib_frontend.c
> @@ -1126,11 +1126,12 @@ static void ip_fib_net_exit(struct net *net)
> {
> unsigned int i;
>
> + rtnl_lock();
> +
> #ifdef CONFIG_IP_MULTIPLE_TABLES
> fib4_rules_exit(net);
> #endif
>
> - rtnl_lock();
> for (i = 0; i < FIB_TABLE_HASHSZ; i++) {
> struct hlist_head *head = &net->ipv4.fib_table_hash[i];
> struct hlist_node *tmp;
Acked-by: Alexander Duyck <alexander.h.duyck@redhat.com>
next prev parent reply other threads:[~2015-03-10 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 18:35 suspicious RCU usage in fib_table_flush_external Sabrina Dubroca
2015-03-10 18:45 ` Alexander Duyck
2015-03-10 20:03 ` [PATCH net-next] fib_trie: call fib_table_flush_external under RTNL Sabrina Dubroca
2015-03-10 20:38 ` Alexander Duyck [this message]
2015-03-11 13:00 ` Jiri Pirko
2015-03-11 20:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FF562B.2060701@redhat.com \
--to=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).