From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ying Xue Subject: Re: [PATCH net-next v2] tipc: fix undefined __ipv6_sock_mc_join compile error Date: Wed, 11 Mar 2015 14:24:48 +0800 Message-ID: <54FFDFB0.6090004@windriver.com> References: <20150310.124742.2005589544373604240.davem@davemloft.net> <54FFB269.10009@windriver.com> <20150311.000512.1167662110194290318.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , , , , , , To: David Miller Return-path: Received: from mail1.windriver.com ([147.11.146.13]:45916 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbbCKGZO (ORCPT ); Wed, 11 Mar 2015 02:25:14 -0400 In-Reply-To: <20150311.000512.1167662110194290318.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 03/11/2015 12:05 PM, David Miller wrote: > From: Ying Xue > Date: Wed, 11 Mar 2015 11:11:37 +0800 > >> On 03/11/2015 12:47 AM, David Miller wrote: >>> From: Willem de Bruijn >>> Date: Tue, 10 Mar 2015 11:41:03 -0400 >>> >>>> On Tue, Mar 10, 2015 at 4:41 AM, Ying Xue wrote: >>>>> @@ -5,6 +5,7 @@ >>>>> menuconfig TIPC >>>>> tristate "The TIPC Protocol" >>>>> depends on INET >>>>> + depends on (IPV6 || IPV6=n) >>>> >>>> Should this be limited to TIPC_MEDIA_UDP? >>> >>> I think it should. >>> >>> >> >> My first thought is also same as you. But when the dependency like (IPV6 || >> IPV6=n) is enforced to TIPC_MEDIA_UDP, it doesn't work in the below case: >> >> IPV6=m and TIPC=Y. >> >> In above condition, TIPC_MEDIA_UDP is still set to "Y". > > It's because TIPC_MEDIA_UDP is bool, it needs to be a tristate. > Yes, you are right. But as we don't implement UDP bearer as a module, I guess we have to set TIPC_MEDIA_UDP as boolean type. Regards, Ying >