From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:50292 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946197AbeCBRrH (ORCPT ); Fri, 2 Mar 2018 12:47:07 -0500 Received: by mail-wm0-f66.google.com with SMTP id w128so4672356wmw.0 for ; Fri, 02 Mar 2018 09:47:06 -0800 (PST) Subject: Re: [PATCH v3 net-next 06/10] net/ipv6: Pass skb to route lookup To: David Ahern , netdev@vger.kernel.org References: <20180302163221.26954-1-dsahern@gmail.com> <20180302163221.26954-7-dsahern@gmail.com> Cc: idosch@idosch.org, davem@davemloft.net, roopa@cumulusnetworks.com, tom@herbertland.com From: Nikolay Aleksandrov Message-ID: <54a6e10e-5fcf-7d45-38be-ed935fe56bd9@cumulusnetworks.com> Date: Fri, 2 Mar 2018 19:47:04 +0200 MIME-Version: 1.0 In-Reply-To: <20180302163221.26954-7-dsahern@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 02/03/18 18:32, David Ahern wrote: > IPv6 does path selection for multipath routes deep in the lookup > functions. The next patch adds L4 hash option and needs the skb > for the forward path. To get the skb to the relevant FIB lookup > functions it needs to go through the fib rules layer, so add a > lookup_data argument to the fib_lookup_arg struct. > > Signed-off-by: David Ahern > Reviewed-by: Ido Schimmel > --- > drivers/infiniband/core/cma.c | 2 +- > drivers/net/ipvlan/ipvlan_core.c | 3 +- > drivers/net/vrf.c | 7 ++-- > include/net/fib_rules.h | 1 + > include/net/ip6_fib.h | 4 ++- > include/net/ip6_route.h | 11 +++--- > net/ipv6/anycast.c | 2 +- > net/ipv6/fib6_rules.c | 8 +++-- > net/ipv6/icmp.c | 3 +- > net/ipv6/ip6_fib.c | 3 +- > net/ipv6/ip6_gre.c | 2 +- > net/ipv6/ip6_tunnel.c | 4 +-- > net/ipv6/ip6_vti.c | 2 +- > net/ipv6/mcast.c | 4 +-- > net/ipv6/netfilter/ip6t_rpfilter.c | 2 +- > net/ipv6/netfilter/nft_fib_ipv6.c | 3 +- > net/ipv6/route.c | 72 +++++++++++++++++++++++--------------- > net/ipv6/seg6_local.c | 4 +-- > 18 files changed, 83 insertions(+), 54 deletions(-) > Indeed, I remember this requirement back when I was making the IPv4 changes and looked into how IPv6 is handled, skb wasn't passed down until now. Looks good to me! Reviewed-by: Nikolay Aleksandrov