From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40FDC433EF for ; Wed, 2 Feb 2022 19:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237230AbiBBTqO (ORCPT ); Wed, 2 Feb 2022 14:46:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229889AbiBBTqN (ORCPT ); Wed, 2 Feb 2022 14:46:13 -0500 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FA45C06173B for ; Wed, 2 Feb 2022 11:46:13 -0800 (PST) Received: by mail-io1-xd2e.google.com with SMTP id r144so400083iod.9 for ; Wed, 02 Feb 2022 11:46:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vt3isMlW6ttVsQJABAGNqW4La/pKobL1/1SkIM0CXj0=; b=Ykc6xHweurUlhClVjJyQxJk2LPsS8tPboKepabrQrVLOUfbbzq0Mr2M9pL1hGItwZ5 Qo2GlCFkWxgFHu4GjXdPflw78dmkLSxaRx+naBgyNQAoB19IQnKK4y7FfI0/1HcMIp3k 3dkmaiIzYxj9Dkb/RL5xmSOctULBwUK59BgWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vt3isMlW6ttVsQJABAGNqW4La/pKobL1/1SkIM0CXj0=; b=zNMbxs68ukzcQEzEBvKZVjgeu4aJf1w0Zae5chW9IBbr+iNwxDzCbQV40mAmTVs3/P eSdO2jHFb1FtZdZ2E9XZGQxdbQoXHwGbJ7jTVAXeYQ4qbeJ8Ge+XXsSjQb1E6eGj96en wFfUkuqGI+1/Ll3TM/SjNcR6cY7GZAEXHHL91iDQxw0n6+ZsE03eJlhkV2kN/VYb5Qoq jOiXEiF3X+I84faqAecW11A9Xtazv8PqvVUmLndpwYAm6h33kB8Eea6ElFcVzmgK3HcW 3q85TXWJWX6dJ5QMPCg1jkPs6zqsySvPZxinQ8V5xTZDXf6psyPxTNFMQDV4cLnHwxlT kDlg== X-Gm-Message-State: AOAM532GQ/1/tXYFAcBK7qvQjdGfQqF4z+7OCwYGYhzPLA827Q9E8miF RlsD+I8ik1eZUupapnMgUKrHdg== X-Google-Smtp-Source: ABdhPJzutUWweN2ZQe0jdrQWkLNljYhOx57TKumMkNAsoHbsw/Dli7kW/F7RJwKzi8yIyt16bzl59A== X-Received: by 2002:a6b:3b8a:: with SMTP id i132mr17522487ioa.85.1643831172924; Wed, 02 Feb 2022 11:46:12 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id k2sm9305443iow.7.2022.02.02.11.46.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Feb 2022 11:46:12 -0800 (PST) Subject: Re: [PATCH net-next] selftests: fib offload: use sensible tos values To: Guillaume Nault , David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Ido Schimmel , Jiri Pirko , Shuah Khan References: <5e43b343720360a1c0e4f5947d9e917b26f30fbf.1643826556.git.gnault@redhat.com> From: Shuah Khan Message-ID: <54a7071e-71ad-0c7d-ccc4-0f85dbe1e077@linuxfoundation.org> Date: Wed, 2 Feb 2022 12:46:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <5e43b343720360a1c0e4f5947d9e917b26f30fbf.1643826556.git.gnault@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/2/22 11:30 AM, Guillaume Nault wrote: > Although both iproute2 and the kernel accept 1 and 2 as tos values for > new routes, those are invalid. These values only set ECN bits, which > are ignored during IPv4 fib lookups. Therefore, no packet can actually > match such routes. This selftest therefore only succeeds because it > doesn't verify that the new routes do actually work in practice (it > just checks if the routes are offloaded or not). > > It makes more sense to use tos values that don't conflict with ECN. > This way, the selftest won't be affected if we later decide to warn or > even reject invalid tos configurations for new routes. Wouldn't it make sense to leave these invalid values in the test though. Removing these makes this test out of sync withe kernel. thanks, -- Shuah