From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Jakub Kicinski <kuba@kernel.org>, Eugene Syromiatnikov <esyr@redhat.com>
Cc: Matt Johnston <matt@codeconstruct.com.au>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/2] MCTP sockaddr padding check/initialisation fixup
Date: Fri, 05 Nov 2021 07:59:17 +0800 [thread overview]
Message-ID: <54b02f37ab63e0e5a0c6fc2912b8652927fdb22f.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20211104165532.781b3dd0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hi Jakub,
> > This pair of patches introduces checks for padding fields of struct
> > sockaddr_mctp/sockaddr_mctp_ext to ease their re-use for possible
> > extensions in the future; as well as zeroing of these fields
> > in the respective sockaddr filling routines. While the first
> > commit
> > is definitely an ABI breakage, it is proposed in hopes that the
> > change
> > is made soon enough (the interface appeared only in Linux 5.15)
> > to avoid affecting any existing user space.
>
> Seems reasonable, Jeremy can you send an ack?
Yep, will do ASAP - I'm planning also send references to the commits
ton the userspace side, so that we have a record of where everything
lines up on the updated ABI.
I'll have that done later today.
Cheers,
Jeremy
next prev parent reply other threads:[~2021-11-04 23:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 19:09 [PATCH net-next v2 0/2] MCTP sockaddr padding check/initialisation fixup Eugene Syromiatnikov
2021-11-03 19:09 ` [PATCH net-next v2 1/2] mctp: handle the struct sockaddr_mctp padding fields Eugene Syromiatnikov
2021-11-03 19:09 ` [PATCH net-next v2 2/2] mctp: handle the struct sockaddr_mctp_ext padding field Eugene Syromiatnikov
2021-11-04 23:55 ` [PATCH net-next v2 0/2] MCTP sockaddr padding check/initialisation fixup Jakub Kicinski
2021-11-04 23:59 ` Jeremy Kerr [this message]
2021-11-05 0:23 ` Jeremy Kerr
2021-11-05 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54b02f37ab63e0e5a0c6fc2912b8652927fdb22f.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=davem@davemloft.net \
--cc=esyr@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).