From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C5483612F1 for ; Sun, 4 Oct 2026 15:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791128132; cv=none; b=hj34l/7kQrFTqH5HQAT291BG3UCHHUka6BRtHTlHqJbbWVs0RE1JPTf4aEftbtiTuhviVwyxzK8CMl36PtIlMhEidTiSWWjvOSWhArc9xohE07CjRMqu2yrDvOtNjWUjAS6znC8UdHr/HbWY07TYKZ6a7j4EHdFHMW60lf7sWoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791128132; c=relaxed/simple; bh=sViDSdZKQRI9ydvQk0h3/BkhqBPxKExmezC30XiSMd8=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=qMrFjO5Czv53RcTj53f0XXFhL1Fezqe1dcEj0s7nD+KzhemtUYtPM/A140fs0izAfGH2xt6fSDBmuZFJ2c7IjBRk1J7YTKcvtHv1yJmEapm+iTlKwIe+2S45t05BTNen9XEvma9qCOgmOx9qtuioz6eJt81fo2TXoURoJOVUrfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49d0da752ffso8566075e9.3 for ; Sun, 04 Oct 2026 08:35:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791128127; x=1791732927; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SwyDMGKhrQUUcZw1khziLYF4shBI37cIxufrD9bOvf4=; b=xI5/CyPVfvWcrUDGg15TtkGHj4yP9ZWtpkZK4cG0MuvRpKKIASdo84O8FszjbusWz+ TX1oNZTKH4JOFHqcHEDRMoIIxnqBMARJ5LiEBxEWw8zDipGYWJQD74lGhJVGzeOwaUb+ pLczuBUO9SLU4RRKItQpdrb4qdMOPOnRXB5+1i+2MrivxoKUTso5trS8qn7+ZLRDfXBd RdbEj55lJP0wXIlWfgl0N6+PcwthkprJOohcJ+l77durYabArQmv+pmHZwCqjgXmLmJL fj9cbk5+gEKp+ELqRQRSDKwAqyMTLjqhpMeBqUn3XHxJIm8oEP+Kftdnc7zTNwwvCO2y MjRg== X-Forwarded-Encrypted: i=1; AKwUvBxuBrqy70NZbsNImbcRDX2uxsmdkLxHgrpJGRxT+vxwPRTQyKxOa1au+s4ZluCMdmLBOCNywlM=@vger.kernel.org X-Gm-Message-State: AFuF++nO4YIf6/wwwTIyJwPQiutSKXvEb8ff1SC+a0f1g4QOTTLemVjT ZS+dhf9a9Csg93sdtIU28E3EqIjupzAGPpCV72k7h5uAnWUVGsMZkIpy X-Gm-Gg: AYBFou2zMNUcIS1u1DPKZcSe/RlCj6gomQrjdET7H1YNlJ5b0MfVFSgNP0zD+E+uPCL dudcHvWLWU5mq4eQJVNl/JQhmspfeJeMCFjJn/erWkwDs7qDg04nP7Ut7IBznLR+OolVpeAJjn1 LnIqaDAxdZpyRoWSuNQlUpKrOjNCI5DC+hU8LK+MQiHre9mG2h/Qi9qDc4UVfF8l/jTjohYwbIc /4+jxLXbyLbrpL3I+CVhX7OQ+OlepwD7mCAH+m9pO1YuKt1vc5kAb6iXIBlo6NLIutEFTQ0IU8y zF7UhzqAkUalM4oUcI0TpuXQLqEqQQfNGges7rHxzgMc6MMiD3SGSBDDlI6vAfmduQggHJAlDZg Koe3Q8/zrRQR8cF5Irx+0areRwVX8tjiVsOoBL1QQ+GZCLoGuYSenaTX3uvtXKxzLPychIcRE23 Dkr2f5ubyECDKiD/efhH+Ik3lUQsc06I1yzPIOPw/f+r3PwR74U9aZU5+NVYtX0NQvA3asop2NF UMbRO0/UumyQ06pHv1Ua/Z5RqwS X-Received: by 2002:a05:600c:348d:b0:4a0:c02:938c with SMTP id 5b1f17b1804b1-4a1680f405fmr76449125e9.25.1791128127431; Sun, 04 Oct 2026 08:35:27 -0700 (PDT) Received: from [192.168.1.135] ([84.68.183.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a0316b2524sm310617265e9.1.2026.10.04.08.35.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Oct 2026 08:35:26 -0700 (PDT) Message-ID: <54b064f8-8e01-44da-be40-4125620ff9d0@linux.com> Date: Sun, 4 Oct 2026 16:35:26 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] dt-bindings: net: meson-dwmac: add T7 support From: Lucas Tanure To: Conor Dooley , xianwei.zhao@amlogic.com Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260924-t7-node-new-v2-0-319d3c19b4b2@amlogic.com> <20260924-t7-node-new-v2-2-319d3c19b4b2@amlogic.com> <20260924-stinger-stoplight-7c327c3225fa@spud> <4460ec4a-1a28-4481-a33e-3fe72f68bf58@linux.com> Content-Language: en-US In-Reply-To: <4460ec4a-1a28-4481-a33e-3fe72f68bf58@linux.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/10/2026 15:06, Lucas Tanure wrote: > On 24/09/2026 18:21, Conor Dooley wrote: >> On Thu, Sep 24, 2026 at 05:51:09AM +0000, Xianwei Zhao via B4 Relay >> wrote: >>> From: Xianwei Zhao >>> >>> Add the T7 compatible to the Meson DWMAC binding. >>> >>> The T7 DWMAC controller requires the following compatible combination: >>> >>> amlogic,t7-dwmac >>> amlogic,meson-axg-dwmac >>> snps,dwmac-4.00 >>> >>> Add a conditional schema check to enforce this compatible combination >>> when amlogic,t7-dwmac is used. >>> >>> Signed-off-by: Xianwei Zhao >>> --- >>>   .../devicetree/bindings/net/amlogic,meson-dwmac.yaml    | 17 ++++++ >>> +++++++++++ >>>   1 file changed, 17 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/amlogic,meson- >>> dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson- >>> dwmac.yaml >>> index 5c91716d1f21..b529ca5577a9 100644 >>> --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml >>> +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml >>> @@ -23,11 +23,24 @@ select: >>>             - amlogic,meson-gxbb-dwmac >>>             - amlogic,meson-axg-dwmac >>>             - amlogic,meson-g12a-dwmac >>> +          - amlogic,t7-dwmac >>>     required: >>>       - compatible >>>   allOf: >>>     - $ref: snps,dwmac.yaml# >>> +  - if: >>> +      properties: >>> +        compatible: >>> +          contains: >>> +            const: amlogic,t7-dwmac >>> +    then: >>> +      properties: >>> +        compatible: >>> +          items: >>> +            - const: amlogic,t7-dwmac >>> +            - const: amlogic,meson-axg-dwmac >>> +            - const: snps,dwmac-4.00 >> >> This is not how fallback compatibles are described. >> >> Instead of doing this, which affects all other compatibles in the file >> by allowing dwmac-4.00 for all devices, please do this the normal way. >> dwmac isn't special, it's just this binding that's weird! >> Can whats currently in the binding (before this patch) be largely >> replaced by just doing: >>    compatible: >>      oneOf: >>        - items: >>            - enum: >>                - amlogic,meson8b-dwmac >>                - amlogic,meson-gxbb-dwmac >>                - amlogic,meson-axg-dwmac >>                - amlogic,meson-g12a-dwmac >>            - const: snps,dwmac-3.70a >>            - const: snps,dwmac >>        - items: >>            - enum: >>                - amlogic,meson6-dwmac >>                - amlogic,meson8m2-dwmac >>            - const: snps,dwmac >> >> You'll have to check this yourself against the amlogic devicetrees and >> see if this is correct, but with this you should be able to add your new >> device without doing anything special. > > I have the same patch in my T7 work and checked it against the amlogic > device trees: meson6 and meson8m2 use the two entry form, the rest add > snps,dwmac-3.70a. dt_binding_check and dtbs_check are clean. The example > needs fixing. > > Xianwei, from my VIM4: the MAC reports Synopsys ID 0x51, DWMAC_CORE_5_10 > in common.h, so the core is 5.10a, not 4.00. And the controller reaches > DRAM through a pipeline stage. Nothing claims its gate, sys_ampipe_eth, > so clk_disable_unused switches it off. My node lists it as a fourth > clock. Does the AN400 differ? > > I will send my series today so the code is on the list. Not a race: I > will drop or rebase whatever overlaps once you tell me. > > Thanks, > Lucas My Ethernet patches https://lore.kernel.org/linux-amlogic/20261004144046.391444-1-tanure@linux.com > >> >> pw-bot: changes-requested >> >> Thanks, >> Conor. >> >>>     - if: >>>         properties: >>>           compatible: >>> @@ -38,6 +51,7 @@ allOf: >>>                 - amlogic,meson-gxbb-dwmac >>>                 - amlogic,meson-axg-dwmac >>>                 - amlogic,meson-g12a-dwmac >>> +              - amlogic,t7-dwmac >>>       then: >>>         properties: >>> @@ -93,6 +107,7 @@ allOf: >>>                 - amlogic,meson8m2-dwmac >>>                 - amlogic,meson-gxbb-dwmac >>>                 - amlogic,meson-axg-dwmac >>> +              - amlogic,t7-dwmac >>>       then: >>>         properties: >>>           rx-internal-delay-ps: >>> @@ -139,8 +154,10 @@ properties: >>>             - amlogic,meson-gxbb-dwmac >>>             - amlogic,meson-axg-dwmac >>>             - amlogic,meson-g12a-dwmac >>> +          - amlogic,t7-dwmac >>>       contains: >>>         enum: >>> +        - snps,dwmac-4.00 >>>           - snps,dwmac-3.70a >>>           - snps,dwmac >>> >>> -- >>> 2.52.0 >>> >>>