* [PATCH net-next] net: stmmac: dwmac-qcom-ethqos: Update link clock rate only for RGMII
@ 2024-02-22 12:55 Sarosh Hasan
2024-02-22 13:01 ` Konrad Dybcio
0 siblings, 1 reply; 3+ messages in thread
From: Sarosh Hasan @ 2024-02-22 12:55 UTC (permalink / raw)
To: Vinod Koul, Bhupesh Sharma, Andy Gross, Bjorn Andersson,
Konrad Dybcio, David S. Miller, Eric Dumazet, Jakub Kicinski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexandre Torgue,
Jose Abreu, Maxime Coquelin, netdev, linux-arm-msm, devicetree,
linux-kernel, linux-stm32, Prasad Sodagudi, Andrew Halaney,
Rob Herring
Cc: kernel, Sneh Shah, Suraj Jaiswal
Updating link clock rate for different speeds is only needed when
using RGMII, as that mode requires changing clock speed when the link
speed changes. Let's restrict updating the link clock speed in
ethqos_update_link_clk() to just RGMII. Other modes such as SGMII
only need to enable the link clock (which is already done in probe).
Signed-off-by: Sarosh Hasan <quic_sarohasa@quicinc.com>
---
.../stmicro/stmmac/dwmac-qcom-ethqos.c | 26 ++++++++++---------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
index 31631e3f89d0..9cd144fb3005 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
@@ -169,21 +169,23 @@ static void rgmii_dump(void *priv)
static void
ethqos_update_link_clk(struct qcom_ethqos *ethqos, unsigned int speed)
{
- switch (speed) {
- case SPEED_1000:
- ethqos->link_clk_rate = RGMII_1000_NOM_CLK_FREQ;
- break;
+ if (phy_interface_mode_is_rgmii(ethqos->phy_mode)) {
+ switch (speed) {
+ case SPEED_1000:
+ ethqos->link_clk_rate = RGMII_1000_NOM_CLK_FREQ;
+ break;
- case SPEED_100:
- ethqos->link_clk_rate = RGMII_ID_MODE_100_LOW_SVS_CLK_FREQ;
- break;
+ case SPEED_100:
+ ethqos->link_clk_rate = RGMII_ID_MODE_100_LOW_SVS_CLK_FREQ;
+ break;
- case SPEED_10:
- ethqos->link_clk_rate = RGMII_ID_MODE_10_LOW_SVS_CLK_FREQ;
- break;
- }
+ case SPEED_10:
+ ethqos->link_clk_rate = RGMII_ID_MODE_10_LOW_SVS_CLK_FREQ;
+ break;
+ }
- clk_set_rate(ethqos->link_clk, ethqos->link_clk_rate);
+ clk_set_rate(ethqos->link_clk, ethqos->link_clk_rate);
+ }
}
static void ethqos_set_func_clk_en(struct qcom_ethqos *ethqos)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: stmmac: dwmac-qcom-ethqos: Update link clock rate only for RGMII
2024-02-22 12:55 [PATCH net-next] net: stmmac: dwmac-qcom-ethqos: Update link clock rate only for RGMII Sarosh Hasan
@ 2024-02-22 13:01 ` Konrad Dybcio
2024-02-26 23:05 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2024-02-22 13:01 UTC (permalink / raw)
To: Sarosh Hasan, Vinod Koul, Bhupesh Sharma, Andy Gross,
Bjorn Andersson, David S. Miller, Eric Dumazet, Jakub Kicinski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexandre Torgue,
Jose Abreu, Maxime Coquelin, netdev, linux-arm-msm, devicetree,
linux-kernel, linux-stm32, Prasad Sodagudi, Andrew Halaney,
Rob Herring
Cc: kernel, Sneh Shah, Suraj Jaiswal
On 2/22/24 13:55, Sarosh Hasan wrote:
> Updating link clock rate for different speeds is only needed when
> using RGMII, as that mode requires changing clock speed when the link
> speed changes. Let's restrict updating the link clock speed in
> ethqos_update_link_clk() to just RGMII. Other modes such as SGMII
> only need to enable the link clock (which is already done in probe).
>
> Signed-off-by: Sarosh Hasan <quic_sarohasa@quicinc.com>
> ---
> .../stmicro/stmmac/dwmac-qcom-ethqos.c | 26 ++++++++++---------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> index 31631e3f89d0..9cd144fb3005 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> @@ -169,21 +169,23 @@ static void rgmii_dump(void *priv)
> static void
> ethqos_update_link_clk(struct qcom_ethqos *ethqos, unsigned int speed)
> {
> - switch (speed) {
> - case SPEED_1000:
> - ethqos->link_clk_rate = RGMII_1000_NOM_CLK_FREQ;
> - break;
> + if (phy_interface_mode_is_rgmii(ethqos->phy_mode)) {
> + switch (speed) {
> + case SPEED_1000:
> + ethqos->link_clk_rate = RGMII_1000_NOM_CLK_FREQ;
> + break;
>
> - case SPEED_100:
> - ethqos->link_clk_rate = RGMII_ID_MODE_100_LOW_SVS_CLK_FREQ;
> - break;
> + case SPEED_100:
> + ethqos->link_clk_rate = RGMII_ID_MODE_100_LOW_SVS_CLK_FREQ;
> + break;
>
> - case SPEED_10:
> - ethqos->link_clk_rate = RGMII_ID_MODE_10_LOW_SVS_CLK_FREQ;
> - break;
> - }
> + case SPEED_10:
> + ethqos->link_clk_rate = RGMII_ID_MODE_10_LOW_SVS_CLK_FREQ;
> + break;
> + }
>
> - clk_set_rate(ethqos->link_clk, ethqos->link_clk_rate);
> + clk_set_rate(ethqos->link_clk, ethqos->link_clk_rate);
> + }
> }
if (!phy_interface_mode_is_rgmii(ethqos->phy_mode))
return 0;
[leave the rest unchanged]
?
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: stmmac: dwmac-qcom-ethqos: Update link clock rate only for RGMII
2024-02-22 13:01 ` Konrad Dybcio
@ 2024-02-26 23:05 ` Andrew Lunn
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2024-02-26 23:05 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Sarosh Hasan, Vinod Koul, Bhupesh Sharma, Andy Gross,
Bjorn Andersson, David S. Miller, Eric Dumazet, Jakub Kicinski,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexandre Torgue,
Jose Abreu, Maxime Coquelin, netdev, linux-arm-msm, devicetree,
linux-kernel, linux-stm32, Prasad Sodagudi, Andrew Halaney,
Rob Herring, kernel, Sneh Shah, Suraj Jaiswal
> > static void
> > ethqos_update_link_clk(struct qcom_ethqos *ethqos, unsigned int speed)
> > {
> > - switch (speed) {
> > - case SPEED_1000:
> > - ethqos->link_clk_rate = RGMII_1000_NOM_CLK_FREQ;
> > - break;
> > + if (phy_interface_mode_is_rgmii(ethqos->phy_mode)) {
> > + switch (speed) {
> > + case SPEED_1000:
> > + ethqos->link_clk_rate = RGMII_1000_NOM_CLK_FREQ;
> > + break;
> > - case SPEED_100:
> > - ethqos->link_clk_rate = RGMII_ID_MODE_100_LOW_SVS_CLK_FREQ;
> > - break;
> > + case SPEED_100:
> > + ethqos->link_clk_rate = RGMII_ID_MODE_100_LOW_SVS_CLK_FREQ;
> > + break;
> > - case SPEED_10:
> > - ethqos->link_clk_rate = RGMII_ID_MODE_10_LOW_SVS_CLK_FREQ;
> > - break;
> > - }
> > + case SPEED_10:
> > + ethqos->link_clk_rate = RGMII_ID_MODE_10_LOW_SVS_CLK_FREQ;
> > + break;
> > + }
> > - clk_set_rate(ethqos->link_clk, ethqos->link_clk_rate);
> > + clk_set_rate(ethqos->link_clk, ethqos->link_clk_rate);
> > + }
> > }
>
> if (!phy_interface_mode_is_rgmii(ethqos->phy_mode))
> return 0;
It is a void function, so no 0, but otherwise this does look less
invasive.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-26 23:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-22 12:55 [PATCH net-next] net: stmmac: dwmac-qcom-ethqos: Update link clock rate only for RGMII Sarosh Hasan
2024-02-22 13:01 ` Konrad Dybcio
2024-02-26 23:05 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).