From: Paolo Abeni <pabeni@redhat.com>
To: Petr Tesarik <ptesarik@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
"open list:NETWORKING [TCP]" <netdev@vger.kernel.org>
Cc: David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 2/2] tcp_metrics: use ssthresh value from dst if there is no metrics
Date: Tue, 17 Jun 2025 12:48:30 +0200 [thread overview]
Message-ID: <54d712a2-31a7-4801-aa65-53746edda117@redhat.com> (raw)
In-Reply-To: <20250613102012.724405-3-ptesarik@suse.com>
On 6/13/25 12:20 PM, Petr Tesarik wrote:
> @@ -537,6 +537,9 @@ void tcp_init_metrics(struct sock *sk)
>
> inet_csk(sk)->icsk_rto = TCP_TIMEOUT_FALLBACK;
> }
> +
> + if (tp->snd_ssthresh > tp->snd_cwnd_clamp)
> + tp->snd_ssthresh = tp->snd_cwnd_clamp;
I don't think we can do this unconditionally, as other parts of the TCP
stack check explicitly for TCP_INFINITE_SSTHRESH.
/P
next prev parent reply other threads:[~2025-06-17 10:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 10:20 [PATCH net 0/2] tcp_metrics: fix hanlding of route options Petr Tesarik
2025-06-13 10:20 ` [PATCH net 1/2] tcp_metrics: set maximum cwnd from the dst entry Petr Tesarik
2025-06-17 11:00 ` Paolo Abeni
2025-06-17 11:39 ` Petr Tesarik
2025-06-18 17:01 ` Petr Tesarik
2025-06-19 8:22 ` Paolo Abeni
2025-06-13 10:20 ` [PATCH net 2/2] tcp_metrics: use ssthresh value from dst if there is no metrics Petr Tesarik
2025-06-17 10:48 ` Paolo Abeni [this message]
2025-06-17 11:56 ` Petr Tesarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54d712a2-31a7-4801-aa65-53746edda117@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ptesarik@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).