From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bkemail.birger-koblitz.de (bkemail.birger-koblitz.de [23.88.97.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BA3F304BDF; Wed, 29 Apr 2026 03:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.97.239 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777434777; cv=none; b=Z8GNA9EN6VrCciOsph6SLs7Sapk7X5UyZQPSbVjLgYRKkjBLgnJQ1Kzjmtsf9nEC66b8rdN8jvnAjXYgz94yYXQcC/BBSyZYihGv7JVoH68WGf1TyvuIawS84cXzxhJ8FI3exeZIeeRGkMTvinnLtAM4k5YyJl09yClClqbAv8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777434777; c=relaxed/simple; bh=B2HX1PM5n3v6UGf6lGhJXaxG5YbV920BqkBbCmtAv4o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F7F7lhP+1k2TM4wAu5xTuGz7NwNzqmdDyTaleDxgzgOs9yvGraaZjiH5mD85IvwW6g8b0Zylm3N44vriXNFkvSxcsn0Hpah1z+B+I3xXsUjrTog6g/fnYEVSk+5XX+DH6pkhqJZ5fQJ1iTJEwirWwxDGMh5sdfVf/nZyhxv/yy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de; spf=pass smtp.mailfrom=birger-koblitz.de; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=oZxOoajT; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b=kWgGRYDo; arc=none smtp.client-ip=23.88.97.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=birger-koblitz.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="oZxOoajT"; dkim=pass (2048-bit key) header.d=birger-koblitz.de header.i=@birger-koblitz.de header.b="kWgGRYDo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1777434769; bh=B2HX1PM5n3v6UGf6lGhJXaxG5YbV920BqkBbCmtAv4o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oZxOoajT+YOjhYwgFm/dXcpF4GKMHC0dJ7VhdNRwkCfqZ4EaFn+OOGZv3nG6gISma SZZP51glOz5DbZVc5Y4S9iZxAkaVzmTPpjrL64KB5i32jcyLnb+GHhxpNB9TA8TCQZ v0QsNyH8Xk3qRdWFpnOibTTY+tcnLFowhG4F359nM9EZO6NemyDQ88Gw6nIU9n+Gva JfQrnHt6G4Beaf2sBNH/7ycKX6i5Nu805jARpni7bTl19RGzplZSchhT1kvH/DQxBX MmxBv0nnfsE9u/TU0gY/LW+SsyoaF9Rm5AMAswgcyYsXF0K7pSy5RncWf4yQNZz7m5 b4xJ0OkaDWeMw== Received: by bkemail.birger-koblitz.de (Postfix, from userid 109) id 41F9047DF8; Wed, 29 Apr 2026 03:52:49 +0000 (UTC) X-Spam-Level: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=birger-koblitz.de; s=default; t=1777434768; bh=B2HX1PM5n3v6UGf6lGhJXaxG5YbV920BqkBbCmtAv4o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kWgGRYDoO7Ge7fBRUGfGegL6TO2Y4W7UcT/wVTyd2U2J4XjJJWuNvoJQb2RA/CVZf SG5n0IiEEkLO8ZzEOiIP8V0QA0StsZpzC3T0LqEjc++fkZ7AVIadQiD2gy/9TMC0vM WwKctpjby1qSSCFuOGTCCjZ2Jteb4GXY29xqzJ5g74wM7rpde+Os2aW0+kSJxADo4c TYEHTq7C5JKSmz/0xCYQIE51sR2y0ZsGyyvzHEUtJpV+yaeeF9RcMYof73nlQJhsib sd4ODOVjApooJVGolS44ZIN2r/T6YiVaeQuhis6mcbNzCC8lS+yO3dqEA5AGBVHmfL /87/8WAqQx9aQ== Received: from [IPV6:2a00:6020:47a3:e800:271c:c6c5:9fde:77cb] (unknown [IPv6:2a00:6020:47a3:e800:271c:c6c5:9fde:77cb]) by bkemail.birger-koblitz.de (Postfix) with ESMTPSA id 5A06646FB3; Wed, 29 Apr 2026 03:52:48 +0000 (UTC) Message-ID: <54e5e249-d947-4b0f-915c-e13bc4f6e345@birger-koblitz.de> Date: Wed, 29 Apr 2026 05:52:47 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/4] r8152: Add support for the RTL8159 chip To: Andrew Lunn Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chih Kai Hsu References: <20260428-rtl8159_net_next-v1-0-52d03927b46f@birger-koblitz.de> <20260428-rtl8159_net_next-v1-2-52d03927b46f@birger-koblitz.de> <3e04d913-693c-44a9-a685-df9d0c9bd95f@lunn.ch> From: Birger Koblitz Content-Language: en-US In-Reply-To: <3e04d913-693c-44a9-a685-df9d0c9bd95f@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Andrew, thanks for reviewing! On 29/04/2026 3:52 am, Andrew Lunn wrote: >> + case RTL_VER_17: >> case RTL_VER_16: >> ocp_byte_clr_bits(tp, MCU_TYPE_PLA, PLA_CR, CR_RE | CR_TE); > > nitpick. The other switch statements seem to be sorted. So 17 should > be after 16. Will fix in the next version. >> + sram_write_w0w1(tp, 0x81b9, 0xff00, 0xb900); >> + //nomal link TX filter > > normal? Please also add a space after the //. netdev also prefers /* > */. Will fix. >> + sram2_write_w0w1(tp, 0x84b2, 0xff00, 0x6000); >> + //Training AAGC PAR (with uc2 patch) > > space Will fix. >> + if (tp->version == RTL_VER_17 && r8159_wait_backup_restore(tp)) >> + return; > > You should probably do something with the return value from > r8159_wait_backup_restore(). At minimum a dev_err(). > I will add a dev_err() message. Birger