Re: [PATCH net-next V2 3/8] devlink: Extend devlink rate API with traffic classes bandwidth management

[Carolina Jubran <cjubran@nvidia.com>]

On 15/11/2024 12:15, Paolo Abeni wrote:
> On 11/14/24 23:09, Tariq Toukan wrote:
>> From: Carolina Jubran <cjubran@nvidia.com>
>>
>> Introduce support for specifying bandwidth proportions between traffic
>> classes (TC) in the devlink-rate API. This new option allows users to
>> allocate bandwidth across multiple traffic classes in a single command.
>>
>> This feature provides a more granular control over traffic management,
>> especially for scenarios requiring Enhanced Transmission Selection.
>>
>> Users can now define a specific bandwidth share for each traffic class,
>> such as allocating 20% for TC0 (TCP/UDP) and 80% for TC5 (RoCE).
>>
>> Example:
>> DEV=pci/0000:08:00.0
>>
>> $ devlink port function rate add $DEV/vfs_group tx_share 10Gbit \
>>    tx_max 50Gbit tc-bw 0:20 1:0 2:0 3:0 4:0 5:80 6:0 7:0
>>
>> $ devlink port function rate set $DEV/vfs_group \
>>    tc-bw 0:20 1:0 2:0 3:0 4:0 5:10 6:60 7:0
>>
>> Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
>> Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
>> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> 
> I haven't dug into it, but this patch is apparently causing netdevsim
> self-tests failures:
> 
> https://netdev-3.bots.linux.dev/vmksft-netdevsim/results/860662/4-devlink-sh/stdout
> 
> Could you please have a look?
> 
> Thanks!
> 
> Paolo
>


Thanks for pointing this out. I’ve identified the issue and will address 
it in v3.