From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Vladimir Oltean <olteanv@gmail.com>,
DENG Qingfang <dqfext@gmail.com>,
Mauri Sandberg <sandberg@mailfence.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dsa: tag_rtl4_a: Bump min packet size
Date: Mon, 30 Oct 2023 00:00:46 +0100 [thread overview]
Message-ID: <54f8d583-e900-4ce8-87d1-a18556698f10@lunn.ch> (raw)
In-Reply-To: <CACRpkdbq03ZXcB-TaBp5Udo3M47rb-o+LfkEkC-gA1+=x1Zd-g@mail.gmail.com>
> 1496 is suspiciously much 1500 - DSA tag size. However the
> MTU of the parent ethernet is bumped nicely to 1504 and the
> device MTU is set up to accomodate it as well.
>
> Modifying the patch to just pad out packets >= 1496 bytes
> solves the problem in a better way, but maybe that is not the
> last thing we try here...
Have you tried playing with RTL8366RB_SGCR in rtl8366rb_change_mtu()?
I had an annoying bug in the mv88e6xxx driver where the MTU
configuration register was up to, but not including... So i had to
change a <= to <.
Andrew
next prev parent reply other threads:[~2023-10-29 23:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 20:21 [PATCH] dsa: tag_rtl4_a: Bump min packet size Linus Walleij
2023-10-27 21:23 ` Florian Fainelli
2023-10-27 23:03 ` Andrew Lunn
2023-10-29 22:18 ` David Laight
2023-10-29 15:38 ` Linus Walleij
2023-10-29 17:35 ` Andrew Lunn
2023-10-30 12:51 ` Vladimir Oltean
2023-10-30 14:29 ` Linus Walleij
2023-10-30 14:32 ` Linus Walleij
2023-10-28 22:04 ` Vladimir Oltean
2023-10-29 22:15 ` Linus Walleij
2023-10-29 23:00 ` Andrew Lunn [this message]
2023-10-30 7:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54f8d583-e900-4ce8-87d1-a18556698f10@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sandberg@mailfence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox