From: Tadeusz Struk <tadeusz.struk@intel.com>
To: David Miller <davem@davemloft.net>, ying.xue@windriver.com
Cc: herbert@gondor.apana.org.au, hch@lst.de, viro@ZenIV.linux.org.uk,
netdev@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: net: Remove iocb argument from sendmsg and recvmsg
Date: Wed, 11 Mar 2015 09:25:40 -0700 [thread overview]
Message-ID: <55006C84.6040406@intel.com> (raw)
In-Reply-To: <20150311.000607.609650379851507833.davem@davemloft.net>
On 03/10/2015 09:06 PM, David Miller wrote:
> From: Ying Xue <ying.xue@windriver.com>
> Date: Wed, 11 Mar 2015 11:18:01 +0800
>
>> Sorry, I did not realize the case when I created the commit. However, although I
>> don't understand its scenario, in my opinion, adding one redundant argument for
>> all sockets to satisfy the special case seems unreasonable for us.
>
> And the AIO socket mechanism was buggy and references freed up stack
> objects.
>
> That whole set of problems would need to be addressed fully before
> we could even think of adding AIO support back to the socket layer.
>
Maybe we can add new sock_aio_read_iter() and sock_aio_write_iter() functions in socket.c, and set the
aio_read() and aio_write() ptrs to these in the socket_file_ops struct.
Then we can add new async_sendmsg() and async_recvmsg() to struct proto_ops that will still take the struct kiocb.
These new async_sendmsg() and async_recvmsg() functions will be called from the sock_aio_read_iter() and sock_aio_write_iter()?
Do you want me to put a patch together?
next prev parent reply other threads:[~2015-03-11 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54FFAA5B.3080608@intel.com>
2015-03-11 3:18 ` net: Remove iocb argument from sendmsg and recvmsg Ying Xue
2015-03-11 3:25 ` Tadeusz Struk
2015-03-11 4:06 ` David Miller
2015-03-11 4:39 ` Tadeusz Struk
2015-03-11 4:06 ` David Miller
2015-03-11 16:25 ` Tadeusz Struk [this message]
2015-03-11 4:02 ` David Miller
2015-03-11 16:09 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55006C84.6040406@intel.com \
--to=tadeusz.struk@intel.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).