From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next 1/6] tcp_metrics: panic when tcp_metrics can not be allocated Date: Wed, 11 Mar 2015 22:22:50 +0300 Message-ID: <5500960A.1010909@cogentembedded.com> References: <871tlxtbhd.fsf_-_@x220.int.ebiederm.org> <87d25hrv9m.fsf@x220.int.ebiederm.org> <20150219.144929.1003473344851168804.davem@davemloft.net> <87h9tu114z.fsf_-_@x220.int.ebiederm.org> <874mpu10xt.fsf_-_@x220.int.ebiederm.org> <54FDEB61.6020501@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: edumazet@google.com, netdev@vger.kernel.org, stephen@networkplumber.org, nicolas.dichtel@6wind.com, roopa@cumulusnetworks.com, hannes@stressinduktion.org, ddutt@cumulusnetworks.com, vipin@cumulusnetworks.com, shmulik.ladkani@gmail.com, dsahern@gmail.com To: "Eric W. Biederman" , David Miller Return-path: Received: from mail-la0-f51.google.com ([209.85.215.51]:33981 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbbCKTWy (ORCPT ); Wed, 11 Mar 2015 15:22:54 -0400 Received: by labgq15 with SMTP id gq15so11105081lab.1 for ; Wed, 11 Mar 2015 12:22:53 -0700 (PDT) In-Reply-To: <54FDEB61.6020501@cogentembedded.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 03/09/2015 09:50 PM, Sergei Shtylyov wrote: >> Panic so that in the unlikely event we have problems we will have a >> clear place to start debugging instead of a mysterious NULL pointer >> deference later on. >> Signed-off-by: "Eric W. Biederman" >> --- >> net/ipv4/tcp_metrics.c | 1 + >> 1 file changed, 1 insertion(+) >> diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c >> index e5f41bd5ec1b..fdf4bdda971f 100644 >> --- a/net/ipv4/tcp_metrics.c >> +++ b/net/ipv4/tcp_metrics.c >> @@ -1186,5 +1186,6 @@ cleanup_subsys: >> unregister_pernet_subsys(&tcp_net_metrics_ops); >> >> cleanup: >> + panic("Could not allocate the tcp_metrics hash table\n"); >> return; > You can drop this *return* as well, it serves not purpose. Ah, it used to have a purpose before your patch... but now it surely doesn't. >> } WBR, Sergei