From: Alexander Duyck <alexander.duyck@gmail.com>
To: David Miller <davem@davemloft.net>, alexander.h.duyck@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH] fib_trie: Only display main table in /proc/net/route
Date: Wed, 11 Mar 2015 18:36:14 -0700 [thread overview]
Message-ID: <5500ED8E.2080507@gmail.com> (raw)
In-Reply-To: <20150311.212228.1581184934531828534.davem@davemloft.net>
On 03/11/2015 06:22 PM, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@redhat.com>
> Date: Wed, 11 Mar 2015 16:36:08 -0700
>
>> When we merged the tries for local and main I had overlooked the iterator
>> for /proc/net/route. As a result it was outputting both local and main
>> when the two tries were merged.
>>
>> This patch resolves that by only providing output for aliases that are
>> actually in the main trie. As a result we should go back to the original
>> behavior which I assume will be necessary to maintain legacy support.
>>
>> Fixes: 0ddcf43d5 ("ipv4: FIB Local/MAIN table collapse")
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
> Applied, thanks Alex.
>
> Please don't put empty lines between Fixes: tags and the signoffs
> and acks, they belong together.
I'll try to remember that for any other patches.
Thanks.
- Alex
next prev parent reply other threads:[~2015-03-12 1:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 23:36 [net-next PATCH] fib_trie: Only display main table in /proc/net/route Alexander Duyck
2015-03-12 1:22 ` David Miller
2015-03-12 1:36 ` Alexander Duyck [this message]
2015-03-12 19:13 ` Eric Dumazet
2015-03-12 19:56 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5500ED8E.2080507@gmail.com \
--to=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).