From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ying Xue Subject: Re: [PATCH net-next v3] tipc: fix undefined __ipv6_sock_mc_join compile error Date: Thu, 12 Mar 2015 11:35:04 +0800 Message-ID: <55010968.5090606@windriver.com> References: <1426060274-2930-1-git-send-email-ying.xue@windriver.com> <20150311.175954.948622401089738977.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , , , , , , To: David Miller Return-path: Received: from mail1.windriver.com ([147.11.146.13]:39898 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbbCLDfa (ORCPT ); Wed, 11 Mar 2015 23:35:30 -0400 In-Reply-To: <20150311.175954.948622401089738977.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 03/12/2015 05:59 AM, David Miller wrote: > From: Ying Xue > Date: Wed, 11 Mar 2015 15:51:13 +0800 > >> diff --git a/net/tipc/Kconfig b/net/tipc/Kconfig >> index c25a3a1..5bb8fc9 100644 >> --- a/net/tipc/Kconfig >> +++ b/net/tipc/Kconfig >> @@ -29,6 +29,7 @@ config TIPC_MEDIA_IB >> config TIPC_MEDIA_UDP >> bool "IP/UDP media type support" >> depends on TIPC >> + depends on (IPV6=y || IPV6=n) >> select NET_UDP_TUNNEL >> help >> Saying Y here will enable support for running TIPC over IP/UDP > > This really is not what you want. > > You want to enable TIPC_MEDIA_UDP if IPV6 is "compatible" with TIPC, > what you're using here is a sledgehammer. > > I would really suggest breaking this facility out into it's own > module, then you can mark it tristate and do this correctly. > > Thank you for the review. OK, I will change the code again following your suggestions. Regards, Ying