From: roopa <roopa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: sfeldma@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/3] switchdev: support stp updates on stacked netdevices
Date: Fri, 13 Mar 2015 18:49:10 -0700 [thread overview]
Message-ID: <55039396.8060305@cumulusnetworks.com> (raw)
In-Reply-To: <20150313.123156.2118585119289960334.davem@davemloft.net>
On 3/13/15, 9:31 AM, David Miller wrote:
> From: roopa <roopa@cumulusnetworks.com>
> Date: Fri, 13 Mar 2015 06:25:24 -0700
>
>> David, if you mean not touch bond and team but have the switchdev
>> api do it transparently, yes, i had it that way initially. And i do
>> liked it that way as well. But the feedback i received (during the
>> initial introduction of this for setlink/dellink) was to make it
>> explicit for each master.
> I think the concern is that we only want to do this for devices
> for which it is safe to "traverse" down like this.
>
> But frankly I cannot think of any layered device where we would
> not want to do this.
>
> Let's go back to the simple scheme where we unconditionally traverse
> and if we hit a problem case we'll figure out how to deal with it
> then, ok?
ok, sounds great. I will respin. Thanks!.
I wanted to move all three ops setlink/dellink/stpupdate initially, but
now realize that
for something like the below to work, you will need the setlink/dellink
support in the
bond and team driver because the call goes into the 'dev' driver
directly without
calling into the switchdev api.
bridge link set dev bond0 learning off self
This case can be fixed too, however, it needs some more work in
rtnetlink.c handling of 'self'.
The stp update api does not have this problem. I will respin the current
stp update series first.
next prev parent reply other threads:[~2015-03-14 1:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 0:29 [PATCH net-next v2 0/3] switchdev: support stp updates on stacked netdevices roopa
2015-03-13 4:10 ` David Miller
2015-03-13 13:25 ` roopa
2015-03-13 16:31 ` David Miller
2015-03-14 1:49 ` roopa [this message]
2015-03-15 16:56 ` Jiri Pirko
2015-03-15 22:30 ` David Miller
2015-03-15 18:08 ` Scott Feldman
2015-03-15 19:17 ` Jiri Pirko
2015-03-15 20:03 ` Scott Feldman
2015-03-15 22:33 ` David Miller
2015-03-16 15:09 ` roopa
2015-03-15 22:32 ` David Miller
2015-03-16 6:37 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55039396.8060305@cumulusnetworks.com \
--to=roopa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).