From: Florian Fainelli <f.fainelli@gmail.com>
To: Or Gerlitz <ogerlitz@mellanox.com>, David Miller <davem@davemloft.net>
Cc: john.r.fastabend@intel.com, netdev@vger.kernel.org,
amirv@mellanox.com, idos@mellanox.com, matanb@mellanox.com
Subject: Re: [PATCH net-next V1 1/3] net: Add max rate tx queue attribute
Date: Mon, 16 Mar 2015 13:01:18 -0700 [thread overview]
Message-ID: <5507368E.6030107@gmail.com> (raw)
In-Reply-To: <550537C2.3080107@mellanox.com>
On 15/03/15 00:41, Or Gerlitz wrote:
> On 3/15/2015 7:07 AM, David Miller wrote:
>> From: Or Gerlitz <ogerlitz@mellanox.com>
>> This is more succinctly expressed as:
>>
>> err = -EOPNOTSUPP;
>> if (dev->netdev_ops->ndo_set_tx_maxrate) {
>> err = dev->netdev_ops->ndo_set_tx_maxrate(dev, index, rate);
>> if (!err) {
>> queue->tx_maxrate = rate;
>> return len;
>> }
>> return err;
>>
>
> sure, I'll fix that.
Can you also include a patch which updates the sysfs documentation at
Documentation/ABI/testing/sysfs-class-net-queues? Thanks!
--
Florian
next prev parent reply other threads:[~2015-03-16 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 8:53 [PATCH net-next V1 0/3] Add max rate TXQ attribute Or Gerlitz
2015-03-12 8:53 ` [PATCH net-next V1 1/3] net: Add max rate tx queue attribute Or Gerlitz
2015-03-15 5:07 ` David Miller
2015-03-15 7:41 ` Or Gerlitz
2015-03-16 20:01 ` Florian Fainelli [this message]
2015-03-16 21:37 ` Tom Herbert
2015-03-12 8:53 ` [PATCH net-next V1 2/3] net/mlx4_core: Add basic support for QP max-rate limiting Or Gerlitz
2015-03-12 8:53 ` [PATCH net-next V1 3/3] net/mlx4_en: Add tx queue maxrate support Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5507368E.6030107@gmail.com \
--to=f.fainelli@gmail.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=idos@mellanox.com \
--cc=john.r.fastabend@intel.com \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).