From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Colin King <colin.king@canonical.com>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: gs_usb: check for kzalloc allocation failure
Date: Tue, 17 Mar 2015 09:04:52 +0100 [thread overview]
Message-ID: <5507E024.9090801@pengutronix.de> (raw)
In-Reply-To: <1426545744-3317-1-git-send-email-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On 03/16/2015 11:42 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> smatch detected the following issue:
> drivers/net/can/usb/gs_usb.c:904 gs_usb_probe() error:
> potential null dereference 'dev'. (kzalloc returns null)
>
> Add a check for null return from kzalloc and return -ENOMEM
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied to can.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-03-17 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 22:42 [PATCH] can: gs_usb: check for kzalloc allocation failure Colin King
2015-03-17 8:04 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5507E024.9090801@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=colin.king@canonical.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).