[PATCH] can: gs_usb: check for kzalloc allocation failure

[PATCH] can: gs_usb: check for kzalloc allocation failure

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

smatch detected the following issue:
drivers/net/can/usb/gs_usb.c:904 gs_usb_probe() error:
   potential null dereference 'dev'.  (kzalloc returns null)

Add a check for null return from kzalloc and return -ENOMEM

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/can/usb/gs_usb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index 009acc8..8b4d3e6 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -901,6 +901,8 @@ static int gs_usb_probe(struct usb_interface *intf, const struct usb_device_id *
 	}
 
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
+	if (!dev)
+		return -ENOMEM;
 	init_usb_anchor(&dev->rx_submitted);
 
 	atomic_set(&dev->active_channels, 0);
-- 
2.1.4

Re: [PATCH] can: gs_usb: check for kzalloc allocation failure

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

On 03/16/2015 11:42 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> smatch detected the following issue:
> drivers/net/can/usb/gs_usb.c:904 gs_usb_probe() error:
>    potential null dereference 'dev'.  (kzalloc returns null)
> 
> Add a check for null return from kzalloc and return -ENOMEM
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, applied to can.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]