Netdev List
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>, Wei Liu <wei.liu2@citrix.com>,
	"Andrew J. Bennieston" <andrew.bennieston@citrix.com>,
	xen-devel@lists.xenproject.org,
	Josh Boyer <jwboyer@fedoraproject.org>
Subject: [PATCH] net: xen-netback: include linux/vmalloc.h again
Date: Tue, 10 Jun 2014 10:34:36 +0200	[thread overview]
Message-ID: <5508988.K5Wec8A6hA@wuerfel> (raw)

commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
queue struct") added a use of vzalloc/vfree to interface.c, but
removed the #include <linux/vmalloc.h> statement at the same time,
which causes this build error:

drivers/net/xen-netback/interface.c: In function 'xenvif_free':
drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
  vfree(vif->queues);
  ^
cc1: some warnings being treated as errors

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
---

I haven't found another report of this bug, but if someone else already
submitted a fix, please ignore this one.

Incidentally, it's the same bug that Josh fixed before in January,
but it has reappeared now, see https://lkml.org/lkml/2014/1/5/36

diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 6929bcb..852da34 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -34,6 +34,7 @@
 #include <linux/ethtool.h>
 #include <linux/rtnetlink.h>
 #include <linux/if_vlan.h>
+#include <linux/vmalloc.h>
 
 #include <xen/events.h>
 #include <asm/xen/hypercall.h>

             reply	other threads:[~2014-06-10  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10  8:34 Arnd Bergmann [this message]
2014-06-10  8:44 ` [PATCH] net: xen-netback: include linux/vmalloc.h again Wei Liu
2014-06-10  8:52   ` [Xen-devel] " Ian Campbell
2014-06-11 22:19   ` David Miller
2014-06-12  9:07     ` Wei Liu
2014-06-11 22:19 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5508988.K5Wec8A6hA@wuerfel \
    --to=arnd@arndb.de \
    --cc=andrew.bennieston@citrix.com \
    --cc=davem@davemloft.net \
    --cc=jwboyer@fedoraproject.org \
    --cc=netdev@vger.kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox