[PATCH] net: 8021q: additionally pass SIOCSHWTSTAMP ioctl flag to, the real device

[PATCH] net: 8021q: additionally pass SIOCSHWTSTAMP ioctl flag to, the real device

[Martin Gerbershagen]

   If vlan devices were used, hardware timestamping did not work. The
   problem was that the SIOCSHWTSTAMP ioctl flag was not passed to the real
   device. This is fixed with this patch.

   Signed-off-by: Martin Gerbershagen <martin.gerbershagen@nokia.com>
---
 net/8021q/vlan_dev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 1f26a1b..91f97b1 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -385,6 +385,7 @@ static int vlan_dev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
        case SIOCGMIIPHY:
        case SIOCGMIIREG:
        case SIOCSMIIREG:
+       case SIOCSHWTSTAMP:
                if (netif_device_present(real_dev) && ops->ndo_do_ioctl)
                        err = ops->ndo_do_ioctl(real_dev, &ifrr, cmd);
                break;
-- 
1.8.4.5

Re: [PATCH] net: 8021q: additionally pass SIOCSHWTSTAMP ioctl flag to, the real device

[David Miller]

From: Martin Gerbershagen <martin.gerbershagen@nokia.com>
Date: Thu, 19 Mar 2015 11:08:36 +0100

> 
>    If vlan devices were used, hardware timestamping did not work. The
>    problem was that the SIOCSHWTSTAMP ioctl flag was not passed to the real
>    device. This is fixed with this patch.
> 
>    Signed-off-by: Martin Gerbershagen <martin.gerbershagen@nokia.com>

Please only submit patches against current sources.

Not only is the SIOCSHWTSTAMP there in vlan_dev_ioctl() already, unlike
your patch SIOCGHWTSTAMP is handled and passed down as well.

In fact it's been that way since 3.17 which was released in October 2014,
that's 5 months ago.

You want everyone reading your patch posting to care enough to review
it properly and integrate it if it is valid, yet you don't care enough
about your own change and the time invested by the developers here
reviewing your work to base your work againt current sources?